Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove OffscreenCanvasEnabled from DeprecatedGlobalSettings #8284

Merged
merged 1 commit into from Jan 6, 2023

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented Jan 6, 2023

ad0f017

Remove OffscreenCanvasEnabled from DeprecatedGlobalSettings
https://bugs.webkit.org/show_bug.cgi?id=250177
rdar://103943700

Reviewed by Ryosuke Niwa.

Use EnabledBySetting instead of EnabledByDeprecatedGlobalSetting.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLCanvasElement.idl:
* Source/WebCore/html/OffscreenCanvas.idl:
* Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setOffscreenCanvasEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::offscreenCanvasEnabled): Deleted.

Canonical link: https://commits.webkit.org/258532@main

a54d977

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe ❌ πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug   πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
  πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
  πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@nt1m nt1m requested review from cdumez and rniwa as code owners January 6, 2023 06:43
@nt1m nt1m self-assigned this Jan 6, 2023
@nt1m nt1m added the DOM For bugs specific to XML/HTML DOM elements (including parsing). label Jan 6, 2023
@nt1m nt1m added the merge-queue Applied to send a pull request to merge-queue label Jan 6, 2023
https://bugs.webkit.org/show_bug.cgi?id=250177
rdar://103943700

Reviewed by Ryosuke Niwa.

Use EnabledBySetting instead of EnabledByDeprecatedGlobalSetting.

* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/html/HTMLCanvasElement.idl:
* Source/WebCore/html/OffscreenCanvas.idl:
* Source/WebCore/html/canvas/OffscreenCanvasRenderingContext2D.idl:
* Source/WebCore/page/DeprecatedGlobalSettings.h:
(WebCore::DeprecatedGlobalSettings::setOffscreenCanvasEnabled): Deleted.
(WebCore::DeprecatedGlobalSettings::offscreenCanvasEnabled): Deleted.

Canonical link: https://commits.webkit.org/258532@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258532@main (ad0f017): https://commits.webkit.org/258532@main

Reviewed commits have been landed. Closing PR #8284 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit ad0f017 into WebKit:main Jan 6, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 6, 2023
@nt1m nt1m deleted the eng/offscreen-canvas-setting branch November 3, 2023 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOM For bugs specific to XML/HTML DOM elements (including parsing).
Projects
None yet
4 participants