AX: Remove AccessibilityObjectModelEnabled setting #8295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 5648195) |
nt1m
requested review from
whsieh,
AndresGonzalezApple,
cookiecrook,
fleizach and
hortont424
nt1m
force-pushed
the
eng/ax-om-setting
branch
from
5648195
to
b104dc1
Compare
|
EWS run on previous version of this PR (hash b104dc1) |
fleizach
approved these changes
Jan 6, 2023
nt1m
force-pushed
the
eng/ax-om-setting
branch
from
b104dc1
to
f3e6168
Compare
nt1m
added
merge-queue
|
EWS run on previous version of this PR (hash f3e6168) |
nt1m
force-pushed
the
eng/ax-om-setting
branch
from
f3e6168
to
ae4ad4d
Compare
|
EWS run on current version of this PR (hash ae4ad4d) |
https://bugs.webkit.org/show_bug.cgi?id=250193 rdar://103943537 Reviewed by Chris Fleizach. The setting does nothing. Also remove SPIs which aren't used internally. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/page/DeprecatedGlobalSettings.h: (WebCore::DeprecatedGlobalSettings::setAccessibilityObjectModelEnabled): Deleted. (WebCore::DeprecatedGlobalSettings::accessibilityObjectModelEnabled): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferences.cpp: (WKPreferencesSetAccessibilityObjectModelEnabled): Deleted. (WKPreferencesGetAccessibilityObjectModelEnabled): Deleted. * Source/WebKit/UIProcess/API/C/WKPreferencesRefPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferenceKeysPrivate.h: * Source/WebKitLegacy/mac/WebView/WebPreferences.mm: (-[WebPreferences accessibilityObjectModelEnabled]): Deleted. (-[WebPreferences setAccessibilityObjectModelEnabled:]): Deleted. * Source/WebKitLegacy/mac/WebView/WebPreferencesPrivate.h: Canonical link: https://commits.webkit.org/258571@main
webkit-early-warning-system
force-pushed
the
eng/ax-om-setting
branch
from
ae4ad4d
to
94dae17
Compare
|
Committed 258571@main (94dae17): https://commits.webkit.org/258571@main Reviewed commits have been landed. Closing PR #8295 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
94dae17
ae4ad4d
🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🛠 🧪 jsc🛠 tv🧪 mac-wk2🧪 mac-AS-debug-wk2🛠 watch-sim