Expose _backgroundWebView, _backgroundContentURL and _backgroundContentIsServiceWorker as _WKWebExtension SPI. #8313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 2bbe682)
|
b-weinstein
approved these changes
Jan 6, 2023
kiaraarose
reviewed
Jan 6, 2023
| @@ -35,6 +35,12 @@ NS_ASSUME_NONNULL_BEGIN | |||
| */ | |||
| @property (nonatomic, getter=_inTestingMode, setter=_setTestingMode:) BOOL _testingMode; | |||
|
|
|||
| /*! @abstract The extension background view used for the extension, or `nil` if the extension does not have background content or it is currently unloaded. */ | |||
There was a problem hiding this comment.
Are there certain files where we should use "`nil`" vs "\c nil"?
There was a problem hiding this comment.
The backticks work in this, just not @param.
|
EWS run on current version of this PR (hash 63dc388)
|
xeenon
added
the
unsafe-merge-queue
…ntIsServiceWorker as _WKWebExtension SPI. https://bugs.webkit.org/show_bug.cgi?id=250221 Reviewed by Brian Weinstein. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtension.mm: (-[_WKWebExtension _backgroundContentIsServiceWorker]): Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContext.mm: (-[_WKWebExtensionContext _backgroundWebView]): Added. (-[_WKWebExtensionContext _backgroundContentURL]): Added. * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionContextPrivate.h: * Source/WebKit/UIProcess/API/Cocoa/_WKWebExtensionPrivate.h: * Source/WebKit/UIProcess/Extensions/Cocoa/WebExtensionContextCocoa.mm: (WebKit::WebExtensionContext::load): Added call to writeStateToStorage() to save the last base URL. (WebKit::WebExtensionContext::backgroundContentURL): Return a null URL instead of asserting. * Source/WebKit/UIProcess/Extensions/WebExtensionContext.h: (WebKit::WebExtensionContext::backgroundWebView const): Added. Canonical link: https://commits.webkit.org/258554@main
webkit-early-warning-system
force-pushed
the
bug/250221
branch
from
63dc388
to
0a3c1ae
Compare
|
Committed 258554@main (0a3c1ae): https://commits.webkit.org/258554@main Reviewed commits have been landed. Closing PR #8313 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0a3c1ae
63dc388
🧪 style🛠 ios🛠 mac🛠 wpe🛠 ios-sim🛠 mac-AS-debug🛠 gtk🛠 wincairo🧪 webkitperl🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 tv🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim