[Filters] Generate serializers for Filter and FilterEffects #8314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shallawa
added
the
Layout and Rendering
|
EWS run on previous version of this PR (hash 3bc0fb2)
|
webkit-ews-buildbot
added
the
merging-blocked
shallawa
removed
the
merging-blocked
shallawa
force-pushed
the
eng/Filters-Generate-serializers-for-Filter-and-FilterEffects
branch
from
3bc0fb2
to
64efd2e
Compare
|
EWS run on previous version of this PR (hash 64efd2e)
|
webkit-ews-buildbot
added
the
merging-blocked
achristensen07
approved these changes
Jan 31, 2023
shallawa
removed
the
merging-blocked
shallawa
force-pushed
the
eng/Filters-Generate-serializers-for-Filter-and-FilterEffects
branch
from
64efd2e
to
c822841
Compare
|
EWS run on current version of this PR (hash c822841) |
https://bugs.webkit.org/show_bug.cgi?id=250220 rdar://103960558 Reviewed by Alex Christensen. Also remove FilterReference and replace it with Ref<Filter> and move the superclass coders to WebCoreArgumentCoders. * Source/WebCore/Headers.cmake: * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/platform/graphics/filters/DistantLightSource.h: (WebCore::DistantLightSource::encode const): Deleted. (WebCore::DistantLightSource::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEBlend.h: (WebCore::FEBlend::encode const): Deleted. (WebCore::FEBlend::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEColorMatrix.h: (WebCore::FEColorMatrix::encode const): Deleted. (WebCore::FEColorMatrix::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEComponentTransfer.h: (WebCore::ComponentTransferFunction::encode const): Deleted. (WebCore::ComponentTransferFunction::decode): Deleted. (WebCore::FEComponentTransfer::encode const): Deleted. (WebCore::FEComponentTransfer::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEComposite.h: (WebCore::FEComposite::encode const): Deleted. (WebCore::FEComposite::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h: (WebCore::FEConvolveMatrix::encode const): Deleted. (WebCore::FEConvolveMatrix::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEDiffuseLighting.cpp: * Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h: (WebCore::FEDiffuseLighting::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEDisplacementMap.h: (WebCore::FEDisplacementMap::encode const): Deleted. (WebCore::FEDisplacementMap::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEDropShadow.h: (WebCore::FEDropShadow::encode const): Deleted. (WebCore::FEDropShadow::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEFlood.h: (WebCore::FEFlood::encode const): Deleted. (WebCore::FEFlood::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEGaussianBlur.h: (WebCore::FEGaussianBlur::encode const): Deleted. (WebCore::FEGaussianBlur::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEImage.h: (WebCore::FEImage::encode const): Deleted. (WebCore::FEImage::decode): Deleted. * Source/WebCore/platform/graphics/filters/FELighting.h: (WebCore::FELighting::lightSource const): (WebCore::FELighting::encode const): Deleted. (WebCore::FELighting::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEMerge.h: (WebCore::FEMerge::encode const): Deleted. (WebCore::FEMerge::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEMorphology.h: (WebCore::FEMorphology::encode const): Deleted. (WebCore::FEMorphology::decode): Deleted. * Source/WebCore/platform/graphics/filters/FEOffset.h: (WebCore::FEOffset::encode const): Deleted. (WebCore::FEOffset::decode): Deleted. * Source/WebCore/platform/graphics/filters/FESpecularLighting.cpp: * Source/WebCore/platform/graphics/filters/FESpecularLighting.h: (WebCore::FESpecularLighting::decode): Deleted. * Source/WebCore/platform/graphics/filters/FETurbulence.h: (WebCore::FETurbulence::encode const): Deleted. (WebCore::FETurbulence::decode): Deleted. * Source/WebCore/platform/graphics/filters/Filter.h: (isType): * Source/WebCore/platform/graphics/filters/PointLightSource.h: (WebCore::PointLightSource::encode const): Deleted. (WebCore::PointLightSource::decode): Deleted. * Source/WebCore/platform/graphics/filters/SpotLightSource.h: (WebCore::SpotLightSource::encode const): Deleted. (WebCore::SpotLightSource::decode): Deleted. * Source/WebCore/platform/graphics/filters/software/FELightingSoftwareApplier.cpp: (WebCore::FELightingSoftwareApplier::apply const): * Source/WebCore/svg/SVGFEDiffuseLightingElement.cpp: (WebCore::SVGFEDiffuseLightingElement::setFilterEffectAttribute): * Source/WebCore/svg/SVGFESpecularLightingElement.cpp: (WebCore::SVGFESpecularLightingElement::setFilterEffectAttribute): * Source/WebCore/svg/graphics/filters/SVGFilterExpression.h: * Source/WebCore/svg/graphics/filters/SVGFilterExpressionReference.h: Copied from Source/WebCore/svg/graphics/filters/SVGFilterExpression.h. (WebCore::SVGFilterExpressionNode::encode const): (WebCore::SVGFilterExpressionNode::decode): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.cpp: (WebKit::RemoteDisplayListRecorder::drawFilteredImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.h: * Source/WebKit/GPUProcess/graphics/RemoteDisplayListRecorder.messages.in: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp: (WebKit::RemoteRenderingBackend::getFilteredImageForImageBuffer): * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.h: * Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.messages.in: * Source/WebKit/Platform/IPC/FilterReference.h: Removed. * Source/WebKit/Scripts/webkit/messages.py: (types_that_cannot_be_forward_declared): * Source/WebKit/Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<LightSource>::encode): (IPC::ArgumentCoder<LightSource>::decode): (IPC::ArgumentCoder<FilterFunction>::encode): (IPC::ArgumentCoder<FilterFunction>::decode): (IPC::ArgumentCoder<FilterEffect>::encode): (IPC::ArgumentCoder<FilterEffect>::decode): (IPC::ArgumentCoder<CSSFilter>::encode): (IPC::ArgumentCoder<CSSFilter>::decode): (IPC::ArgumentCoder<SVGFilter>::encode): (IPC::ArgumentCoder<SVGFilter>::decode): (IPC::ArgumentCoder<Filter>::encode): (IPC::ArgumentCoder<Filter>::decode): * Source/WebKit/Shared/WebCoreArgumentCoders.h: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/WebKit.xcodeproj/project.pbxproj: * Source/WebKit/WebProcess/GPU/graphics/RemoteDisplayListRecorderProxy.cpp: (WebKit::RemoteDisplayListRecorderProxy::recordDrawFilteredImageBuffer): * Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp: (WebKit::RemoteRenderingBackendProxy::getFilteredImage): Canonical link: https://commits.webkit.org/259862@main
webkit-early-warning-system
force-pushed
the
eng/Filters-Generate-serializers-for-Filter-and-FilterEffects
branch
from
c822841
to
c4f56fe
Compare
|
Committed 259862@main (c4f56fe): https://commits.webkit.org/259862@main Reviewed commits have been landed. Closing PR #8314 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
shallawa
deleted the
eng/Filters-Generate-serializers-for-Filter-and-FilterEffects
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c4f56fe
c822841
🧪 mac-AS-debug-wk2