[css-transitions] css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property.html is a failure

[anttijk]

e72cc27

[css-transitions] css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property.html is a failure
https://bugs.webkit.org/show_bug.cgi?id=249640
rdar://103549960

Reviewed by Antoine Quint.

* LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution-expected.txt:
* LayoutTests/fast/css/getComputedStyle/getComputedStyle-style-resolution.html:

Change the test to verify that sibling cases don't trigger recalc.

* LayoutTests/imported/w3c/web-platform-tests/css/css-properties-values-api/animation/custom-property-transition-inherited-used-by-standard-property-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute-expected.txt:
* Source/WebCore/css/ComputedStyleExtractor.cpp:
(WebCore::hasValidStyleForProperty):

Remove an optimization where we try to avoid style recalc while having a invalid ancestor style. This can't be done in general case
since there can be complex relationships between properties (via var() and em units for example).

The optimization is narrow and probably not valuable in practice.

(WebCore::isImplicitlyInheritedGridOrFlexProperty): Deleted.
(WebCore::nonInheritedColorPropertyHasValueCurrentColor): Deleted.

Canonical link: https://commits.webkit.org/258714@main

16333a0

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
❌ 🛠 🧪 merge	✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 9a41611)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	💥 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	❌ 🧪 mac-wk2
	✅ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
	✅ 🛠 watch-sim

[graouts]

Looks like fast/css/getComputedStyle/getComputedStyle-style-resolution.html regressed and imported/w3c/web-platform-tests/css/css-variables/variable-presentation-attribute.html progressed. Maybe the former is not accurate though, it's not a WPT anyway.

[webkit-early-warning-system]

EWS run on current version of this PR (hash 16333a0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk2
	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress
❌ 🛠 🧪 merge	✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

[webkit-commit-queue]

Committed 258714@main (e72cc27): https://commits.webkit.org/258714@main

Reviewed commits have been landed. Closing PR #8391 and removing active labels.