[GStreamer][WebCodecs] Video encoding and decoding support #8399

philn · 2023-01-09T16:30:56Z

`c6f4630`

[GStreamer][WebCodecs] Video encoding and decoding support
https://bugs.webkit.org/show_bug.cgi?id=249972

Reviewed by Xabier Rodriguez-Calvar.

The video encoder makes use of the WebRTC encoder. The video decoder relies on the platform decoder
previously probed through the registry scanner. In order to have integrate the encoding and decoding
at the lowest level possible we make use of a new component called GstElementHarness, so we have
full control on the input and output workflow of the encoder and decoder.

* LayoutTests/platform/glib/TestExpectations:
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp8-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt: Added.
* LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt: Added.
* Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml:
* Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp:
(WebCore::WebCodecsVideoFrame::create):
* Source/WebCore/platform/GStreamer.cmake:
* Source/WebCore/platform/VideoDecoder.cpp:
(WebCore::VideoDecoder::createLocalDecoder):
* Source/WebCore/platform/VideoEncoder.cpp:
(WebCore::VideoEncoder::createLocalEncoder):
* Source/WebCore/platform/VideoFrame.cpp:
(WebCore::VideoFrame::paintInContext):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: Added.
(WebCore::gstWorkQueue):
(WebCore::GStreamerInternalVideoDecoder::create):
(WebCore::GStreamerInternalVideoDecoder::postTask):
(WebCore::GStreamerInternalVideoDecoder::close):
(WebCore::GStreamerVideoDecoder::create):
(WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder):
(WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder):
(WebCore::GStreamerVideoDecoder::decode):
(WebCore::GStreamerVideoDecoder::flush):
(WebCore::GStreamerVideoDecoder::reset):
(WebCore::GStreamerVideoDecoder::close):
(WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder):
(WebCore::GStreamerInternalVideoDecoder::decode):
(WebCore::GStreamerInternalVideoDecoder::flush):
* Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h: Added.
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: Added.
(WebCore::gstWorkQueue):
(WebCore::GStreamerInternalVideoEncoder::create):
(WebCore::GStreamerInternalVideoEncoder::postTask):
(WebCore::GStreamerInternalVideoEncoder::close):
(WebCore::GStreamerInternalVideoEncoder::harness const):
(WebCore::GStreamerInternalVideoEncoder::isClosed const):
(WebCore::GStreamerVideoEncoder::create):
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::~GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::initialize):
(WebCore::GStreamerVideoEncoder::encode):
(WebCore::GStreamerVideoEncoder::flush):
(WebCore::GStreamerVideoEncoder::reset):
(WebCore::GStreamerVideoEncoder::close):
(WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder):
(WebCore::GStreamerInternalVideoEncoder::initialize):
(WebCore::GStreamerInternalVideoEncoder::encode):
(WebCore::GStreamerInternalVideoEncoder::flush):
* Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h: Added.
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp:
(WebCore::GstSampleColorConverter::convertSample):
(WebCore::GstSampleColorConverter::convertSampleToImage):
(WebCore::VideoFrame::fromNativeImage):
(WebCore::copyToGstBufferPlane):
(WebCore::VideoFrame::createNV12):
(WebCore::VideoFrame::createRGBA):
(WebCore::VideoFrame::createBGRA):
(WebCore::VideoFrame::createI420):
(WebCore::VideoFrameGStreamer::create):
(WebCore::VideoFrameGStreamer::createWrappedSample):
(WebCore::VideoFrameGStreamer::VideoFrameGStreamer):
(WebCore::copyPlane):
(WebCore::VideoFrame::copyTo):
(WebCore::VideoFrame::paintInContext):
* Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h:
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: Added.
(WebCore::GStreamerElementHarness::GStreamerElementHarness):
(WebCore::GStreamerElementHarness::~GStreamerElementHarness):
(WebCore::GStreamerElementHarness::start):
(WebCore::GStreamerElementHarness::pushStickyEvents):
(WebCore::GStreamerElementHarness::pushSample):
(WebCore::GStreamerElementHarness::pushBuffer):
(WebCore::GStreamerElementHarness::pushEvent):
(WebCore::GStreamerElementHarness::pullBuffer):
(WebCore::GStreamerElementHarness::pullEvent):
(WebCore::GStreamerElementHarness::outputCaps):
(WebCore::GStreamerElementHarness::chainBuffer):
(WebCore::GStreamerElementHarness::sinkQuery):
(WebCore::GStreamerElementHarness::sinkEvent):
(WebCore::GStreamerElementHarness::srcQuery):
(WebCore::GStreamerElementHarness::srcEvent):
(WebCore::GStreamerElementHarness::processOutputBuffers):
(WebCore::GStreamerElementHarness::flush):
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: Added.
(WebCore::GStreamerElementHarness::create):
(WebCore::GStreamerElementHarness::element const):
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsWPE.cmake:
* Tools/TestWebKitAPI/PlatformGTK.cmake:
* Tools/TestWebKitAPI/PlatformWPE.cmake:
* Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp: Added.
(TestWebKitAPI::TEST_F):

Canonical link: https://commits.webkit.org/258949@main

19f922e

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	💥 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
❌ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

webkit-early-warning-system · 2023-01-09T16:34:22Z

EWS run on previous version of this PR (hash 10f0602)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	✅ 🛠 wpe	💥 🛠 🧪 win
✅ 🧪 bindings	❌ 🛠 ios-sim	❌ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	❌ 🧪 api-mac	~~🧪 gtk-wk2~~
	❌ 🧪 api-ios	❌ 🧪 mac-wk1	~~🧪 api-gtk~~
✅ 🛠 🧪 jsc	❌ 🛠 tv	❌ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	❌ 🛠 tv-sim	❌ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	❌ 🛠 watch	❌ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	❌ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

philn · 2023-01-09T16:35:53Z

I wasn't able to make style-check happy. This is too cryptic for me:

ERROR: /var/home/phil/WebKit/LayoutTests/platform/glib/TestExpectations:1152: More specific entry for imported/w3c/web-platform-tests/webcodecs/videoFrame-texImage.any.worker.html on line LayoutTests/platform/glib/TestExpectations:1152 overrides line LayoutTests/platform/glib/TestExpectations:1151. [test/expectations] [5]
Total errors found: 1 in 26 files

webkit-early-warning-system · 2023-01-09T17:02:14Z

EWS run on previous version of this PR (hash e3453ea)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	❌ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	❌ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

LayoutTests/platform/glib/TestExpectations

calvaris · 2023-01-11T09:48:14Z

Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp

+    return VideoFrameGStreamer::create(WTFMove(sample), presentationSize);
+}
+
+RefPtr<VideoFrame> VideoFrame::createBGRA(Span<const uint8_t> span, size_t width, size_t height, const ComputedPlaneLayout& plane, PlatformVideoColorSpace&& colorSpace)


Maybe you can rework these two functions to use the same code but a flag variable? Am I missing any other difference? Not big deal anyway.

I can refactor this with a macro.

I am not a big fan of macros, TBH

Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

Source/WebCore/platform/VideoDecoder.cpp

webkit-early-warning-system · 2023-01-12T15:02:59Z

EWS run on previous version of this PR (hash 2dc05e0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	❌ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

philn · 2023-01-12T18:18:31Z

I can reproduce the webrtc/vp9.html crash in release (bt useless) but not in debug, so... 🤷🏻

webkit-early-warning-system · 2023-01-13T10:23:09Z

EWS run on previous version of this PR (hash 33a3aae)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	⏳ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	⏳ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	⏳ 🧪 api-mac	❌ 🧪 gtk-wk2
	✅ 🧪 api-ios	⏳ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	⏳ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	⏳ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

philn · 2023-01-13T11:44:02Z

I can reproduce the webrtc/vp9.html crash in release (bt useless) but not in debug, so... 🤷🏻

Actually, this is due to the llvm15 update! The test also crashes in main for builds made with clang15. Gonna revert that one.

webkit-early-warning-system · 2023-01-13T12:32:54Z

EWS run on previous version of this PR (hash cfbab24)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🧪 api-mac	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

calvaris · 2023-01-16T10:08:10Z

Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

+        GstCaps* filter = nullptr;
+        GRefPtr<GstCaps> caps;
+        if (m_outputCaps)
+            caps = m_outputCaps.get();


Why do you need to keep the .get() ? I think you don't

Actually, the way it was before, I think it was leaking.

Good catch!

calvaris · 2023-01-16T10:08:59Z

Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp

+        GstCaps* filter = nullptr;
+        GRefPtr<GstCaps> caps;
+        if (m_inputCaps)
+            caps = m_inputCaps.get();


webkit-early-warning-system · 2023-01-16T10:21:21Z

EWS run on current version of this PR (hash 19f922e)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	❌ 🛠 wpe	💥 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-AS-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	~~🧪 api-mac~~	~~🧪 gtk-wk2~~
	✅ 🧪 api-ios	✅ 🧪 mac-wk1	✅ 🧪 api-gtk
✅ 🛠 🧪 jsc	✅ 🛠 tv	✅ 🧪 mac-wk2	✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64	✅ 🛠 tv-sim	✅ 🧪 mac-AS-debug-wk2	✅ 🧪 jsc-armv7-tests
	✅ 🛠 watch	✅ 🧪 mac-wk2-stress	✅ 🛠 jsc-mips
❌ 🛠 🧪 merge	✅ 🛠 watch-sim		✅ 🧪 jsc-mips-tests

https://bugs.webkit.org/show_bug.cgi?id=249972 Reviewed by Xabier Rodriguez-Calvar. The video encoder makes use of the WebRTC encoder. The video decoder relies on the platform decoder previously probed through the registry scanner. In order to have integrate the encoding and decoding at the lowest level possible we make use of a new component called GstElementHarness, so we have full control on the input and output workflow of the encoder and decoder. * LayoutTests/platform/glib/TestExpectations: * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_h264-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp8-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/temporal-svc-encoding.https.any.worker_vp9-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-createImageBitmap.any-expected.txt: Added. * LayoutTests/platform/glib/imported/w3c/web-platform-tests/webcodecs/videoFrame-drawImage.any-expected.txt: Added. * Source/WTF/Scripts/Preferences/UnifiedWebPreferences.yaml: * Source/WebCore/Modules/webcodecs/WebCodecsVideoFrame.cpp: (WebCore::WebCodecsVideoFrame::create): * Source/WebCore/platform/GStreamer.cmake: * Source/WebCore/platform/VideoDecoder.cpp: (WebCore::VideoDecoder::createLocalDecoder): * Source/WebCore/platform/VideoEncoder.cpp: (WebCore::VideoEncoder::createLocalEncoder): * Source/WebCore/platform/VideoFrame.cpp: (WebCore::VideoFrame::paintInContext): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.cpp: Added. (WebCore::gstWorkQueue): (WebCore::GStreamerInternalVideoDecoder::create): (WebCore::GStreamerInternalVideoDecoder::postTask): (WebCore::GStreamerInternalVideoDecoder::close): (WebCore::GStreamerVideoDecoder::create): (WebCore::GStreamerVideoDecoder::GStreamerVideoDecoder): (WebCore::GStreamerVideoDecoder::~GStreamerVideoDecoder): (WebCore::GStreamerVideoDecoder::decode): (WebCore::GStreamerVideoDecoder::flush): (WebCore::GStreamerVideoDecoder::reset): (WebCore::GStreamerVideoDecoder::close): (WebCore::GStreamerInternalVideoDecoder::GStreamerInternalVideoDecoder): (WebCore::GStreamerInternalVideoDecoder::decode): (WebCore::GStreamerInternalVideoDecoder::flush): * Source/WebCore/platform/graphics/gstreamer/VideoDecoderGStreamer.h: Added. * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.cpp: Added. (WebCore::gstWorkQueue): (WebCore::GStreamerInternalVideoEncoder::create): (WebCore::GStreamerInternalVideoEncoder::postTask): (WebCore::GStreamerInternalVideoEncoder::close): (WebCore::GStreamerInternalVideoEncoder::harness const): (WebCore::GStreamerInternalVideoEncoder::isClosed const): (WebCore::GStreamerVideoEncoder::create): (WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder): (WebCore::GStreamerVideoEncoder::~GStreamerVideoEncoder): (WebCore::GStreamerVideoEncoder::initialize): (WebCore::GStreamerVideoEncoder::encode): (WebCore::GStreamerVideoEncoder::flush): (WebCore::GStreamerVideoEncoder::reset): (WebCore::GStreamerVideoEncoder::close): (WebCore::GStreamerInternalVideoEncoder::GStreamerInternalVideoEncoder): (WebCore::GStreamerInternalVideoEncoder::initialize): (WebCore::GStreamerInternalVideoEncoder::encode): (WebCore::GStreamerInternalVideoEncoder::flush): * Source/WebCore/platform/graphics/gstreamer/VideoEncoderGStreamer.h: Added. * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.cpp: (WebCore::GstSampleColorConverter::convertSample): (WebCore::GstSampleColorConverter::convertSampleToImage): (WebCore::VideoFrame::fromNativeImage): (WebCore::copyToGstBufferPlane): (WebCore::VideoFrame::createNV12): (WebCore::VideoFrame::createRGBA): (WebCore::VideoFrame::createBGRA): (WebCore::VideoFrame::createI420): (WebCore::VideoFrameGStreamer::create): (WebCore::VideoFrameGStreamer::createWrappedSample): (WebCore::VideoFrameGStreamer::VideoFrameGStreamer): (WebCore::copyPlane): (WebCore::VideoFrame::copyTo): (WebCore::VideoFrame::paintInContext): * Source/WebCore/platform/graphics/gstreamer/VideoFrameGStreamer.h: * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: Added. (WebCore::GStreamerElementHarness::GStreamerElementHarness): (WebCore::GStreamerElementHarness::~GStreamerElementHarness): (WebCore::GStreamerElementHarness::start): (WebCore::GStreamerElementHarness::pushStickyEvents): (WebCore::GStreamerElementHarness::pushSample): (WebCore::GStreamerElementHarness::pushBuffer): (WebCore::GStreamerElementHarness::pushEvent): (WebCore::GStreamerElementHarness::pullBuffer): (WebCore::GStreamerElementHarness::pullEvent): (WebCore::GStreamerElementHarness::outputCaps): (WebCore::GStreamerElementHarness::chainBuffer): (WebCore::GStreamerElementHarness::sinkQuery): (WebCore::GStreamerElementHarness::sinkEvent): (WebCore::GStreamerElementHarness::srcQuery): (WebCore::GStreamerElementHarness::srcEvent): (WebCore::GStreamerElementHarness::processOutputBuffers): (WebCore::GStreamerElementHarness::flush): * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: Added. (WebCore::GStreamerElementHarness::create): (WebCore::GStreamerElementHarness::element const): * Source/cmake/OptionsGTK.cmake: * Source/cmake/OptionsWPE.cmake: * Tools/TestWebKitAPI/PlatformGTK.cmake: * Tools/TestWebKitAPI/PlatformWPE.cmake: * Tools/TestWebKitAPI/Tests/WebCore/gstreamer/GstElementHarness.cpp: Added. (TestWebKitAPI::TEST_F): Canonical link: https://commits.webkit.org/258949@main

webkit-commit-queue · 2023-01-16T12:01:57Z

Committed 258949@main (c6f4630): https://commits.webkit.org/258949@main

Reviewed commits have been landed. Closing PR #8399 and removing active labels.

philn requested a review from a team as a code owner January 9, 2023 16:30

philn force-pushed the eng/249972 branch from 352cd97 to 10f0602 Compare January 9, 2023 16:30

philn self-assigned this Jan 9, 2023

philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 9, 2023

philn requested a review from calvaris January 9, 2023 16:31

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 9, 2023

philn removed the merging-blocked Applied to prevent a change from being merged label Jan 9, 2023

philn force-pushed the eng/249972 branch from 10f0602 to e3453ea Compare January 9, 2023 17:01

mcatanzaro reviewed Jan 9, 2023

View reviewed changes

LayoutTests/platform/glib/TestExpectations Outdated Show resolved Hide resolved

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 9, 2023

calvaris reviewed Jan 11, 2023

View reviewed changes

philn removed the merging-blocked Applied to prevent a change from being merged label Jan 12, 2023

philn force-pushed the eng/249972 branch from e3453ea to 2dc05e0 Compare January 12, 2023 15:02

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 12, 2023

philn removed the merging-blocked Applied to prevent a change from being merged label Jan 13, 2023

philn force-pushed the eng/249972 branch from 2dc05e0 to 33a3aae Compare January 13, 2023 10:23

webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 13, 2023

philn removed the merging-blocked Applied to prevent a change from being merged label Jan 13, 2023

philn force-pushed the eng/249972 branch from 33a3aae to cfbab24 Compare January 13, 2023 12:32

philn requested a review from calvaris January 13, 2023 12:34

calvaris approved these changes Jan 16, 2023

View reviewed changes

philn force-pushed the eng/249972 branch from cfbab24 to 19f922e Compare January 16, 2023 10:21

philn added the merge-queue Applied to send a pull request to merge-queue label Jan 16, 2023

webkit-early-warning-system force-pushed the eng/249972 branch from 19f922e to 93ae0b1 Compare January 16, 2023 11:58

webkit-early-warning-system force-pushed the eng/249972 branch from 93ae0b1 to c6f4630 Compare January 16, 2023 12:01

webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 16, 2023

webkit-early-warning-system merged commit c6f4630 into WebKit:main Jan 16, 2023

philn deleted the eng/249972 branch January 16, 2023 12:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[GStreamer][WebCodecs] Video encoding and decoding support #8399

[GStreamer][WebCodecs] Video encoding and decoding support #8399

philn commented Jan 9, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jan 9, 2023 •

edited

philn commented Jan 9, 2023

webkit-early-warning-system commented Jan 9, 2023 •

edited

calvaris Jan 11, 2023

philn Jan 11, 2023

calvaris Jan 12, 2023

philn Jan 12, 2023

webkit-early-warning-system commented Jan 12, 2023 •

edited

philn commented Jan 12, 2023

webkit-early-warning-system commented Jan 13, 2023 •

edited

philn commented Jan 13, 2023

webkit-early-warning-system commented Jan 13, 2023 •

edited

calvaris Jan 16, 2023

calvaris Jan 16, 2023

philn Jan 16, 2023

calvaris Jan 16, 2023

webkit-early-warning-system commented Jan 16, 2023 •

edited

webkit-commit-queue commented Jan 16, 2023

[GStreamer][WebCodecs] Video encoding and decoding support #8399

[GStreamer][WebCodecs] Video encoding and decoding support #8399

Conversation

philn commented Jan 9, 2023 • edited by webkit-early-warning-system

webkit-early-warning-system commented Jan 9, 2023 • edited

philn commented Jan 9, 2023

webkit-early-warning-system commented Jan 9, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 12, 2023 • edited

philn commented Jan 12, 2023

webkit-early-warning-system commented Jan 13, 2023 • edited

philn commented Jan 13, 2023

webkit-early-warning-system commented Jan 13, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

webkit-early-warning-system commented Jan 16, 2023 • edited

webkit-commit-queue commented Jan 16, 2023

philn commented Jan 9, 2023 •

edited by webkit-early-warning-system

webkit-early-warning-system commented Jan 9, 2023 •

edited

webkit-early-warning-system commented Jan 9, 2023 •

edited

webkit-early-warning-system commented Jan 12, 2023 •

edited

webkit-early-warning-system commented Jan 13, 2023 •

edited

webkit-early-warning-system commented Jan 13, 2023 •

edited

webkit-early-warning-system commented Jan 16, 2023 •

edited