[Cocoa] CTFontCreateForCharactersWithLanguageAndOption() is available on all Cocoa platforms #8435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litherum
added
the
Text
|
EWS run on previous version of this PR (hash d2e9fe3) |
hortont424
approved these changes
Jan 10, 2023
hortont424
approved these changes
Jan 10, 2023
litherum
force-pushed
the
eng/Cocoa-CTFontCreateForCharactersWithLanguageAndOption-is-available-on-all-Cocoa-platforms
branch
from
d2e9fe3
to
2f394a6
Compare
|
EWS run on current version of this PR (hash 2f394a6) |
… on all Cocoa platforms https://bugs.webkit.org/show_bug.cgi?id=250363 rdar://104063789 Reviewed by Tim Horton. Simply unify the codepaths. * Source/WTF/wtf/PlatformHave.h: * Source/WebCore/platform/graphics/cocoa/FontCacheCoreText.cpp: (WebCore::preparePlatformFont): (WebCore::createFontForCharacters): (WebCore::FontCache::prewarm): * Source/WebCore/platform/graphics/cocoa/FontDatabase.cpp: (WebCore::FontDatabase::InstalledFont::InstalledFont): (WebCore::FontDatabase::collectionForFamily): (WebCore::FontDatabase::fontForPostScriptName): * Source/WebCore/platform/graphics/cocoa/FontDatabase.h: Canonical link: https://commits.webkit.org/258710@main
webkit-early-warning-system
force-pushed
the
eng/Cocoa-CTFontCreateForCharactersWithLanguageAndOption-is-available-on-all-Cocoa-platforms
branch
from
2f394a6
to
b81575a
Compare
|
Committed 258710@main (b81575a): https://commits.webkit.org/258710@main Reviewed commits have been landed. Closing PR #8435 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b81575a
2f394a6
🛠 🧪 win🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios