Disallow MSE with mp4 should AVStreamDataParser be non-functional #8439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 17d1039)
|
youennf
approved these changes
Jan 10, 2023
| @@ -208,6 +208,13 @@ AtomString codec() const override | |||
|
|
|||
| MediaPlayerEnums::SupportsType SourceBufferParserAVFObjC::isContentTypeSupported(const ContentType& type) | |||
| { | |||
| // Check that AVStreamDataParser is in a functional state. | |||
| if (!PAL::getAVStreamDataParserClass()) { | |||
There was a problem hiding this comment.
Suggested change
| if (!PAL::getAVStreamDataParserClass()) { | |
| if (PAL::getAVStreamDataParserClass()) { |
There was a problem hiding this comment.
oops, I had actually fixed that but didn't commit it, again a last minute change trying to change the code flow :(
jyavenard
force-pushed
the
eng/Disallow-MSE-with-mp4-should-AVStreamDataParser-be-non-functional
branch
from
17d1039
to
8e5eecd
Compare
|
EWS run on current version of this PR (hash 8e5eecd)
|
https://bugs.webkit.org/show_bug.cgi?id=250367 rdar://104065947 Reviewed by Youenn Fablet. On iPhone, MSE is disabled by default. It can be enabled using an experimental setting, however it is mostly non-functional as the SourceBufferParserAVFObjC relies on AVStreamDataParser class which itself is non-functional. So testing for the availability of this class isn't sufficient, we need to test that the init method itself doesn't return nil. No test, as currently all MSE tests are disabled on iOS, and enabling those is out of scope for this change.i On other platforms, covered by existing tests. * Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm: (WebCore::SourceBufferParserAVFObjC::isContentTypeSupported): Canonical link: https://commits.webkit.org/258716@main
webkit-early-warning-system
force-pushed
the
eng/Disallow-MSE-with-mp4-should-AVStreamDataParser-be-non-functional
branch
from
8e5eecd
to
1f86058
Compare
|
Committed 258716@main (1f86058): https://commits.webkit.org/258716@main Reviewed commits have been landed. Closing PR #8439 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1f86058
8e5eecd
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2