Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused WebPage::InteractionRegions IPC #845

Merged
merged 0 commits into from May 20, 2022
Merged

Remove unused WebPage::InteractionRegions IPC #845

merged 0 commits into from May 20, 2022

Conversation

hortont424
Copy link
Contributor

@hortont424 hortont424 commented May 20, 2022 •
edited by webkit-early-warning-system

2d87ce8

Remove unused WebPage::InteractionRegions IPC
https://bugs.webkit.org/show_bug.cgi?id=240725

Reviewed by Wenson Hsieh.

* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::interactionRegions): Deleted.
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::interactionRegions): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
* Source/WebKit/WebProcess/WebPage/WebPage.messages.in:

Canonical link: https://commits.webkit.org/250824@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@hortont424 hortont424 self-assigned this May 20, 2022
@hortont424 hortont424 added WebKit Nightly Build WebKit2 Bugs relating to the WebKit2 API layer labels May 20, 2022
@hortont424 hortont424 added the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Remove-unused-WebPageInteractionRegions-IPC branch from 4bf1783 to 2d87ce8 Compare May 20, 2022 23:43
@webkit-early-warning-system webkit-early-warning-system merged commit 2d87ce8 into WebKit:main May 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294591 (250824@main): https://commits.webkit.org/250824@main

Reviewed commits have been landed. Closing PR #845 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
@hortont424 hortont424 deleted the eng/Remove-unused-WebPageInteractionRegions-IPC branch June 6, 2022 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@whsieh whsieh whsieh approved these changes

@grorg grorg Awaiting requested review from grorg

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

Assignees

@hortont424 hortont424

Labels
WebKit2 Bugs relating to the WebKit2 API layer
Projects
None yet
Milestone
No milestone
3 participants
@hortont424 @webkit-early-warning-system @whsieh