Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null check frame in CachedResourceLoader::updateRequestAfterRedirection #8461

Merged
merged 1 commit into from Jan 10, 2023
Merged

Null check frame in CachedResourceLoader::updateRequestAfterRedirection #8461

merged 1 commit into from Jan 10, 2023

Conversation

achristensen07
Copy link
Contributor

@achristensen07 achristensen07 commented Jan 10, 2023 •
edited by webkit-early-warning-system

547312c

Null check frame in CachedResourceLoader::updateRequestAfterRedirection
https://bugs.webkit.org/show_bug.cgi?id=250391
rdar://103833306

Reviewed by Chris Dumez.

Crash logs indicate the line that used the frame was crashing with null dereferences.
Add some null checks to not crash during frame teardown.

* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):

Canonical link: https://commits.webkit.org/258728@main

a17aaaa

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@achristensen07 achristensen07 self-assigned this Jan 10, 2023
@achristensen07 achristensen07 added the Page Loading For bugs in page loading, including handling of network callbacks. label Jan 10, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash a17aaaa)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

cdumez
cdumez approved these changes Jan 10, 2023
View reviewed changes
Copy link
Contributor

@cdumez cdumez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achristensen07 achristensen07 added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 10, 2023
@achristensen07
Null check frame in CachedResourceLoader::updateRequestAfterRedirection
547312c 
https://bugs.webkit.org/show_bug.cgi?id=250391
rdar://103833306

Reviewed by Chris Dumez.

Crash logs indicate the line that used the frame was crashing with null dereferences.
Add some null checks to not crash during frame teardown.

* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::updateRequestAfterRedirection):

Canonical link: https://commits.webkit.org/258728@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Null-check-frame-in-CachedResourceLoaderupdateRequestAfterRedirection branch from a17aaaa to 547312c Compare January 10, 2023 17:43
@webkit-commit-queue
Copy link
Collaborator

Committed 258728@main (547312c): https://commits.webkit.org/258728@main

Reviewed commits have been landed. Closing PR #8461 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 547312c into WebKit:main Jan 10, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdumez cdumez cdumez approved these changes

Assignees

@achristensen07 achristensen07

Labels
Page Loading For bugs in page loading, including handling of network callbacks.
Projects
None yet
Milestone
No milestone
4 participants
@achristensen07 @webkit-early-warning-system @webkit-commit-queue @cdumez