Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gamepad.vibrationActuator should be [SameObject] #8485

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 10, 2023

@cdumez cdumez self-assigned this Jan 10, 2023
@cdumez cdumez added the WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit). label Jan 10, 2023
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test case!

@cdumez cdumez added the merge-queue Applied to send a pull request to merge-queue label Jan 10, 2023
https://bugs.webkit.org/show_bug.cgi?id=250413

Reviewed by Brent Fulgham.

Gamepad.vibrationActuator should be [SameObject]"
- https://w3c.github.io/gamepad/extensions.html#partial-gamepad-interface

* LayoutTests/gamepad/gamepad-vibrationActuator-SameObject-expected.txt: Added.
* LayoutTests/gamepad/gamepad-vibrationActuator-SameObject.html: Added.
* Source/WebCore/Modules/gamepad/Gamepad.idl:

Canonical link: https://commits.webkit.org/258761@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258761@main (326ecbf): https://commits.webkit.org/258761@main

Reviewed commits have been landed. Closing PR #8485 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 326ecbf into WebKit:main Jan 11, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebCore Misc. For miscellaneous bugs in the WebCore framework (and not JavaScriptCore or WebKit).
Projects
None yet
4 participants