Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null pointer web content crash in AsyncScrollingCoordinator callback #8498

Merged
merged 1 commit into from Jan 11, 2023

Conversation

rr-codes
Copy link
Contributor

@rr-codes rr-codes commented Jan 11, 2023

@rr-codes rr-codes requested a review from cdumez as a code owner January 11, 2023 00:45
@rr-codes rr-codes self-assigned this Jan 11, 2023
@rr-codes rr-codes added the Scrolling Bugs related to main thread and off-main thread scrolling label Jan 11, 2023
@rr-codes rr-codes requested a review from smfr January 11, 2023 00:46
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 11, 2023
@rr-codes rr-codes added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 11, 2023
https://bugs.webkit.org/show_bug.cgi?id=250426
rdar://104099969

Reviewed by Simon Fraser.

Adds a null check for `m_page` in the hysteresis callback of `AsyncScrollingCoordinator`.

* Source/WebCore/page/scrolling/AsyncScrollingCoordinator.cpp:
(WebCore::AsyncScrollingCoordinator::hysterisisTimerFired):

Canonical link: https://commits.webkit.org/258792@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258792@main (d1c8002): https://commits.webkit.org/258792@main

Reviewed commits have been landed. Closing PR #8498 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scrolling Bugs related to main thread and off-main thread scrolling
Projects
None yet
5 participants