Gamepad.vibrationActuator should be nullable #8539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdumez
added
the
WebCore Misc.
cdumez
requested review from
youennf,
achristensen07,
beidson,
brentfulgham and
geoffreygaren
|
EWS run on current version of this PR (hash a6beec0)
|
https://bugs.webkit.org/show_bug.cgi?id=250411 Reviewed by Brent Fulgham. Gamepad.vibrationActuator should be nullable: - w3c/gamepad#178 Gamepad.vibrationActuator is supposed to return null if the gamepad doesn't support dual-rumble: - https://w3c.github.io/gamepad/extensions.html#gamepadhapticactuator-interface (Construction section) * LayoutTests/gamepad/gamepad-event-handlers.html: * LayoutTests/gamepad/gamepad-polling-access.html: * LayoutTests/gamepad/gamepad-timestamp.html: * LayoutTests/gamepad/gamepad-vibrationActuator-SameObject.html: * LayoutTests/gamepad/gamepad-vibrationActuator-nullable-expected.txt: Added. * LayoutTests/gamepad/gamepad-vibrationActuator-nullable.html: Added. * LayoutTests/gamepad/gamepad-vibrationActuator-playEffect-validation.html: * LayoutTests/gamepad/gamepad-vibrationActuator-type.html: * LayoutTests/gamepad/gamepad-visibility-1.html: * Source/WebCore/Modules/gamepad/Gamepad.cpp: (WebCore::Gamepad::Gamepad): (WebCore::Gamepad::vibrationActuator): Deleted. * Source/WebCore/Modules/gamepad/Gamepad.h: * Source/WebCore/Modules/gamepad/Gamepad.idl: * Source/WebCore/testing/MockGamepad.cpp: (WebCore::MockGamepad::MockGamepad): (WebCore::MockGamepad::updateDetails): * Source/WebCore/testing/MockGamepad.h: * Source/WebCore/testing/MockGamepadProvider.cpp: (WebCore::MockGamepadProvider::setMockGamepadDetails): * Source/WebCore/testing/MockGamepadProvider.h: * Source/WebCore/testing/js/WebCoreTestSupport.cpp: (WebCoreTestSupport::setMockGamepadDetails): * Source/WebCore/testing/js/WebCoreTestSupport.h: * Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl: * Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp: (WTR::TestRunner::setMockGamepadDetails): * Tools/WebKitTestRunner/InjectedBundle/TestRunner.h: * Tools/WebKitTestRunner/TestInvocation.cpp: (WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle): Canonical link: https://commits.webkit.org/258812@main
webkit-commit-queue
force-pushed
the
250411_vibrationActuator_nullable
branch
from
a6beec0
to
3d4e479
Compare
|
Committed 258812@main (3d4e479): https://commits.webkit.org/258812@main Reviewed commits have been landed. Closing PR #8539 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3d4e479
a6beec0
🧪 ios-wk2🧪 api-mac🧪 api-ios🧪 api-gtk🧪 mac-AS-debug-wk2