-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JSC] Use SlowPathFrameTracer and fix most of wasm GC operations #8561
[JSC] Use SlowPathFrameTracer and fix most of wasm GC operations #8561
Conversation
0a51454
to
9f26bf3
Compare
EWS run on previous version of this PR (hash 9f26bf3)
|
9f26bf3
to
57ff377
Compare
EWS run on previous version of this PR (hash 57ff377)
|
57ff377
to
cafc4e5
Compare
EWS run on current version of this PR (hash cafc4e5)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me
https://bugs.webkit.org/show_bug.cgi?id=250502 rdar://104156324 Reviewed by Mark Lam. Use SlowPathFrameTracer to configure topCallFrame in Wasm LLInt SlowPathes. And remove storeTopCallFrame since it is no longer used: it was originally introduced to make VM separate from Wasm::Instance etc. while keeping the functionality of setting a CallFrame* to VM. But now we wiped this abstraction, so this SlowPathFrameTracer change cleans up things. We also fix bugs of wasm GC operations where they do not set topCallFrame correctly. They need to set it since they do GC allocation, which can cause ShadowChicken processing, and it requires topCallFrame. This patch fixes them. * Source/JavaScriptCore/wasm/WasmInstance.h: (JSC::Wasm::Instance::storeTopCallFrame): Deleted. * Source/JavaScriptCore/wasm/WasmSlowPaths.cpp: (JSC::LLInt::WASM_SLOW_PATH_DECL): (JSC::LLInt::slow_path_wasm_throw_exception): Canonical link: https://commits.webkit.org/258824@main
cafc4e5
to
31ae64f
Compare
Committed 258824@main (31ae64f): https://commits.webkit.org/258824@main Reviewed commits have been landed. Closing PR #8561 and removing active labels. |
31ae64f
cafc4e5
π wincairoπ§ͺ api-gtkπ jsc-mipsπ§ͺ jsc-mips-tests