Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imported/w3c/web-platform-tests/feature-policy/reporting/encrypted-media-reporting.https.html is a constant crash #8601

Merged
merged 1 commit into from Jan 13, 2023
Merged

imported/w3c/web-platform-tests/feature-policy/reporting/encrypted-media-reporting.https.html is a constant crash #8601

merged 1 commit into from Jan 13, 2023

Conversation

jyavenard
Copy link
Member

@jyavenard jyavenard commented Jan 13, 2023 •
edited by webkit-early-warning-system

b7cf9b0

imported/w3c/web-platform-tests/feature-policy/reporting/encrypted-media-reporting.https.html is a constant crash
https://bugs.webkit.org/show_bug.cgi?id=250534
rdar://104200900

Reviewed by Tim Horton.

On iOS AVStreamDataParser::init will manual release the instance.
If that pointer was stored in a RetainPtr it would lead to a double-release.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::isContentTypeSupported):

Canonical link: https://commits.webkit.org/258861@main

9df325a

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jyavenard jyavenard self-assigned this Jan 13, 2023
@jyavenard jyavenard added the New Bugs Unclassified bugs are placed in this component until the correct component can be determined. label Jan 13, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9df325a)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios   🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@jyavenard jyavenard added the merge-queue Applied to send a pull request to merge-queue label Jan 13, 2023
@jyavenard
imported/w3c/web-platform-tests/feature-policy/reporting/encrypted-me…
b7cf9b0 
…dia-reporting.https.html is a constant crash

https://bugs.webkit.org/show_bug.cgi?id=250534
rdar://104200900

Reviewed by Tim Horton.

On iOS AVStreamDataParser::init will manual release the instance.
If that pointer was stored in a RetainPtr it would lead to a double-release.

* Source/WebCore/platform/graphics/avfoundation/objc/SourceBufferParserAVFObjC.mm:
(WebCore::SourceBufferParserAVFObjC::isContentTypeSupported):

Canonical link: https://commits.webkit.org/258861@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/REGRESSION258716main--iOS--importedw3cweb-platform-testsfeature-policyreportingencrypted-media-reporting-https-html-is-a-constant-crash branch from 9df325a to b7cf9b0 Compare January 13, 2023 05:10
@webkit-commit-queue
Copy link
Collaborator

Committed 258861@main (b7cf9b0): https://commits.webkit.org/258861@main

Reviewed commits have been landed. Closing PR #8601 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit b7cf9b0 into WebKit:main Jan 13, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

Assignees

@jyavenard jyavenard

Labels
New Bugs Unclassified bugs are placed in this component until the correct component can be determined.
Projects
None yet
Milestone
No milestone
4 participants
@jyavenard @webkit-early-warning-system @webkit-commit-queue @hortont424