Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up some fast/text layout tests #861

Merged
merged 0 commits into from May 20, 2022
Merged

Clean up some fast/text layout tests #861

merged 0 commits into from May 20, 2022

Conversation

smfr
Copy link
Contributor

@smfr smfr commented May 20, 2022 •
edited by webkit-early-warning-system

b832db4

Clean up some fast/text layout tests
https://bugs.webkit.org/show_bug.cgi?id=240738

Reviewed by Myles C. Maxfield.

Move Ahem-COLR.ttf from fast/text/canvas-color-fonts/resources to fast/text/resources
so a future non-canvas test can use it.

Create a fast/text/glyph-display-lists directory to host more future glyph
display list tests.

Remove platform/ios/fast/text/softHyphen-expected.txt because the test is a ref test.

* LayoutTests/TestExpectations:
* LayoutTests/fast/text/canvas-color-fonts/COLR-expected.html:
* LayoutTests/fast/text/canvas-color-fonts/COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/ctm-COLR-expected.html:
* LayoutTests/fast/text/canvas-color-fonts/ctm-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-color-COLR-expected.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-color-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-color-shadow-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-color-shadow-ctm-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-gradient-COLR-2.html:
* LayoutTests/fast/text/canvas-color-fonts/fill-gradient-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/linedash-COLR-expected-mismatch.html:
* LayoutTests/fast/text/canvas-color-fonts/linedash-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/linedash-outlines-expected-mismatch.html:
* LayoutTests/fast/text/canvas-color-fonts/linedash-outlines.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-color-COLR-expected.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-color-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-color-shadow-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-color-shadow-ctm-COLR.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-2.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-3.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-4.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR-5.html:
* LayoutTests/fast/text/canvas-color-fonts/stroke-gradient-COLR.html:
* LayoutTests/fast/text/glyph-display-lists/glyph-display-list-color-expected.txt: Renamed from LayoutTests/fast/text/glyph-display-list-color-expected.txt.
* LayoutTests/fast/text/glyph-display-lists/glyph-display-list-color.html: Renamed from LayoutTests/fast/text/glyph-display-list-color.html.
* LayoutTests/fast/text/resources/Ahem-COLR.ttf: Renamed from LayoutTests/fast/text/canvas-color-fonts/resources/Ahem-COLR.ttf.
* LayoutTests/platform/ios/fast/text/softHyphen-expected.txt: Removed.

Canonical link: https://commits.webkit.org/250820@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@smfr smfr self-assigned this May 20, 2022
@smfr smfr added Safari Technology Preview Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels May 20, 2022
@smfr smfr requested a review from litherum May 20, 2022 21:52
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Clean-up-some-fasttext-layout-tests branch from c7ac353 to b832db4 Compare May 20, 2022 22:37
@webkit-early-warning-system webkit-early-warning-system merged commit b832db4 into WebKit:main May 20, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294587 (250820@main): https://commits.webkit.org/250820@main

Reviewed commits have been landed. Closing PR #861 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litherum litherum litherum approved these changes

Assignees

@smfr smfr

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
3 participants
@smfr @webkit-early-warning-system @litherum