REGRESSION(258448@main): [GTK] Missing header with libwebrtc (USE_GSTREAMER_WEBRTC=FALSE) #8628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash e729fdb)
|
|
To facilitate searching for commits, please write "[GTK]" instead of "[WebKitGTK]" |
aperezdc
approved these changes
Jan 13, 2023
manuelafm
force-pushed
the
eng/WebKitGTK-REGRESSION258448main-Missing-header-with-libwebrtc-USE_GSTREAMER_WEBRTCFALSE
branch
from
e729fdb
to
a37afe8
Compare
manuelafm
changed the title
|
EWS run on current version of this PR (hash a37afe8)
|
…REAMER_WEBRTC=FALSE) https://bugs.webkit.org/show_bug.cgi?id=250573 Reviewed by Adrian Perez de Castro. When using libwebrtc (USE_GSTREAMER_WEBRTC=FALSE) since commit 9def6e6, there's a compiler error: --------- In file included from /home/build/WebKit/Source/WebKit/UIProcess/WebPreferences.h:33, from /home/build/WebKit/Source/WebKit/UIProcess/API/glib/WebKitSettingsPrivate.h:31, from /home/build/WebKit/Tools/TestWebKitAPI/Tests/WebKitGLib/TestUIClient.cpp:23: /home/build/WebKit/WebKitBuild/Release/WebCore/PrivateHeaders/WebCore/LibWebRTCProvider.h:37:10: fatal error: webrtc/api/peer_connection_interface.h: No such file or directory 37 | #include <webrtc/api/peer_connection_interface.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. ---------- This adds the necessary directories search for a successful compilation. * Tools/TestWebKitAPI/glib/CMakeLists.txt: Canonical link: https://commits.webkit.org/258892@main
webkit-commit-queue
force-pushed
the
eng/WebKitGTK-REGRESSION258448main-Missing-header-with-libwebrtc-USE_GSTREAMER_WEBRTCFALSE
branch
from
a37afe8
to
ee71929
Compare
|
Committed 258892@main (ee71929): https://commits.webkit.org/258892@main Reviewed commits have been landed. Closing PR #8628 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ee71929
a37afe8
🛠 mac🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🧪 mac-AS-debug-wk2🧪 mac-wk2-stress