WKHTTPCookieStoreDeleteAllCookies should wait for response from network process before invoking callback #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rk process before invoking callback https://bugs.webkit.org/show_bug.cgi?id=240743 Reviewed by NOBODY (OOPS!). Make API::HTTPCookieStore::deleteAllCookies actually wait for the NetworkProcess to complete the operation before calling the completion handler. * Source/WebKit/NetworkProcess/Cookies/WebCookieManager.cpp: (WebKit::WebCookieManager::deleteAllCookies): * Source/WebKit/NetworkProcess/Cookies/WebCookieManager.h: * Source/WebKit/NetworkProcess/Cookies/WebCookieManager.messages.in: * Source/WebKit/UIProcess/API/APIHTTPCookieStore.cpp: (API::HTTPCookieStore::deleteAllCookies): * Source/WebKit/UIProcess/WebCookieManagerProxy.cpp: (WebKit::WebCookieManagerProxy::deleteAllCookies): * Source/WebKit/UIProcess/WebCookieManagerProxy.h:
yury-s
added
WebKit Nightly Build
WebKit2
|
I don't see any C-API tests under Tools/TestWebKitAPI/Tests/WebKit/ that would navigate to an "http:" url, so would appreciates any pointer on how to add a test for this. |
webkit-early-warning-system
added
the
merging-blocked
|
Closing as it was addressed in b720285 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c5db694