Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ATSPI] Implement AccessibilityUIElement::sortDirection() #8686

Merged
merged 1 commit into from Jan 17, 2023
Merged

[ATSPI] Implement AccessibilityUIElement::sortDirection() #8686

merged 1 commit into from Jan 17, 2023

Conversation

obyknovenius
Copy link
Contributor

@obyknovenius obyknovenius commented Jan 16, 2023 •
edited by webkit-early-warning-system

8d89210

[ATSPI] Implement `AccessibilityUIElement::sortDirection()`
https://bugs.webkit.org/show_bug.cgi?id=250673

Reviewed by Carlos Garcia Campos.

It is used by `accessibility/custom-elements/table.html`.

* LayoutTests/accessibility/custom-elements/table.html:
* LayoutTests/platform/gtk/accessibility/custom-elements/table-expected.txt:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::sortDirection const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::sortDirection const):
* Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::sortDirection const):

Canonical link: https://commits.webkit.org/258975@main

7a82cec

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@obyknovenius obyknovenius requested review from a team and JonWBedard as code owners January 16, 2023 12:26
@obyknovenius obyknovenius self-assigned this Jan 16, 2023
@obyknovenius obyknovenius added the Accessibility For bugs related to accessibility. label Jan 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash d79df86)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@obyknovenius obyknovenius added the request-merge-queue Request a pull request to be added to merge-queue once ready label Jan 16, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 7a82cec)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2   🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@aperezdc aperezdc added merge-queue Applied to send a pull request to merge-queue and removed request-merge-queue Request a pull request to be added to merge-queue once ready labels Jan 17, 2023
@obyknovenius @aperezdc
[ATSPI] Implement AccessibilityUIElement::sortDirection()
8d89210 
https://bugs.webkit.org/show_bug.cgi?id=250673

Reviewed by Carlos Garcia Campos.

It is used by `accessibility/custom-elements/table.html`.

* LayoutTests/accessibility/custom-elements/table.html:
* LayoutTests/platform/gtk/accessibility/custom-elements/table-expected.txt:
* Tools/WebKitTestRunner/InjectedBundle/AccessibilityUIElement.cpp:
(WTR::AccessibilityUIElement::sortDirection const): Deleted.
* Tools/WebKitTestRunner/InjectedBundle/atspi/AccessibilityUIElementAtspi.cpp:
(WTR::AccessibilityUIElement::sortDirection const):
* Tools/WebKitTestRunner/InjectedBundle/win/AccessibilityUIElementWin.cpp:
(WTR::AccessibilityUIElement::sortDirection const):

Canonical link: https://commits.webkit.org/258975@main
@webkit-commit-queue
Copy link
Collaborator

Committed 258975@main (8d89210): https://commits.webkit.org/258975@main

Reviewed commits have been landed. Closing PR #8686 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8d89210 into WebKit:main Jan 17, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 17, 2023
@obyknovenius obyknovenius deleted the atspi/sort-direction branch January 19, 2023 18:13
@obyknovenius obyknovenius mentioned this pull request Jan 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosgcampos carlosgcampos carlosgcampos approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@obyknovenius obyknovenius

Labels
Accessibility For bugs related to accessibility.
Projects
None yet
Milestone
No milestone
5 participants
@obyknovenius @webkit-early-warning-system @webkit-commit-queue @carlosgcampos @aperezdc