Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RenderLayer::setHasVisibleContent shouldn't call dirtyZOrderLists() #8695

Closed
wants to merge 1 commit into from

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Jan 16, 2023

RenderLayer::setHasVisibleContent shouldn't call dirtyZOrderLists()
https://bugs.webkit.org/show_bug.cgi?id=250283

Reviewed by NOBODY (OOPS!).

Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=175708

This patch remove FIXME and also dead code since there is no connection
between being visible and z-order lists.
There is no reason to mark the z-order list as dirty when changing visibility status.

* Source/WebCore/rendering/RenderLayer.cpp:
(RenderLayer::setHasVisibleContent): Remove 'dirtyZOrderList'

2633ede

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe πŸ’₯ πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  watch-sim

RenderLayer::setHasVisibleContent shouldn't call dirtyZOrderLists()
https://bugs.webkit.org/show_bug.cgi?id=250283

Reviewed by NOBODY (OOPS!).

Merge - https://src.chromium.org/viewvc/blink?view=rev&revision=175708

This patch remove FIXME and also dead code since there is no connection between
being visible and z-order lists.
There is no reason to mark the z-order list as dirty when changing visibility status.

* Source/WebCore/rendering/RenderLayer.cpp:
(RenderLayer::setHasVisibleContent): Remove 'dirtyZOrderList'
@Ahmad-S792 Ahmad-S792 self-assigned this Jan 16, 2023
@Ahmad-S792 Ahmad-S792 added the Layout and Rendering For bugs with layout and rendering of Web pages. label Jan 16, 2023
@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review January 16, 2023 16:13
@smfr
Copy link
Contributor

smfr commented Jan 16, 2023

I think we may still need this code in WebKitLegacy. RenderLayer::collectLayers() only collects visibility:hidden layers if includeHiddenLayers is true, and that's only true when compositing is enabled. In WebKitLegacy, we enter compositing mode dynamically.

@Ahmad-S792 Ahmad-S792 closed this Jan 16, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix250283-dirtyzOrderList branch February 22, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
3 participants