Revert [259000@main] Web Inspector: WebKit-internal JSContexts should not be inspectable, even if internal policies would override inspectable
#8733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robert-jenner
requested review from
a team,
cdumez and
patrickangle
as code owners
robert-jenner
added
Web Inspector
… not be inspectable, even if internal policies would override `inspectable` https://bugs.webkit.org/show_bug.cgi?id=250633 rdar://103312497 Unreviewed revert. * Source/JavaScriptCore/API/JSRemoteInspector.cpp: (JSRemoteInspectorSetInspectionEnabledByDefault): (JSRemoteInspectorGetInspectionFollowsInternalPolicies): Deleted. (JSRemoteInspectorSetInspectionFollowsInternalPolicies): Deleted. * Source/JavaScriptCore/API/JSRemoteInspector.h: * Source/JavaScriptCore/inspector/JSGlobalObjectInspectorController.cpp: (Inspector::JSGlobalObjectInspectorController::developerExtrasEnabled const): * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.cpp: (Inspector::RemoteInspectionTarget::remoteControlAllowed const): (Inspector::RemoteInspectionTarget::inspectable const): (Inspector::RemoteInspectionTarget::setInspectable): (Inspector::RemoteInspectionTarget::pauseWaitingForAutomaticInspection): (Inspector::RemoteInspectionTarget::allowsInspectionByPolicy const): Deleted. * Source/JavaScriptCore/inspector/remote/RemoteInspectionTarget.h: * Source/JavaScriptCore/inspector/remote/cocoa/RemoteInspectorCocoa.mm: (Inspector::RemoteInspector::listingForInspectionTarget const): * Source/JavaScriptCore/inspector/remote/glib/RemoteInspectorGlib.cpp: (Inspector::RemoteInspector::listingForInspectionTarget const): * Source/JavaScriptCore/inspector/remote/socket/RemoteInspectorSocket.cpp: (Inspector::RemoteInspector::listingForInspectionTarget const): * Source/WebCore/bindings/js/JSDOMGlobalObject.cpp: (WebCore::JSDOMGlobalObject::finishCreation): * Source/WebKit/UIProcess/API/Cocoa/APISerializedScriptValueCocoa.mm: (API::SharedJSContext::ensureContext): Canonical link: https://commits.webkit.org/259004@main
webkit-early-warning-system
force-pushed
the
eng/103312497
branch
from
e9684b0
to
c9e1cf5
Compare
|
Committed 259004@main (c9e1cf5): https://commits.webkit.org/259004@main Reviewed commits have been landed. Closing PR #8733 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash e9684b0) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
c9e1cf5
e9684b0
🛠 mac🛠 🧪 win🛠 gtk🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🛠 tv🧪 mac-wk2🛠 🧪 jsc-arm64🛠 tv-sim🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests🛠 watch🧪 mac-wk2-stress🧪 jsc-mips-tests