Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix duplicate timeupdate events in Text Track Code #8745

Merged

Conversation

Ahmad-S792
Copy link
Contributor

@Ahmad-S792 Ahmad-S792 commented Jan 18, 2023

afdf40a

Fix duplicate timeupdate events in Text Track Code

Fix duplicate timeupdate events in Text Track Code
https://bugs.webkit.org/show_bug.cgi?id=250741

Reviewed by Eric Carlson.

Merge - https://chromium.googlesource.com/chromium/blink/+/fd62a2259d085146f7fb275f99edb80e0e80243b

This change prevents duplicate timeupdate events caused by the text
track code. The comment above the call indicates that the timeupdate
event should have the same restrictions as the normal periodic
timeupdate event. By changing the parameter passed to
scheduleTimeupdateEvent() to true, the event rate limiting guards
are properly applied to this call and duplicate events won't
fire.

* Source/WebCore/html/HTMLMediaElement.cpp:
(HTMLMediaElement::updateActiveTextTrackCues): Update 'scheduleTimeUpdateEvent' to 'true' to have event rate limit

Canonical link: https://commits.webkit.org/259023@main

f1c6d31

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

Copy link
Contributor

@eric-carlson eric-carlson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

r=me

@Ahmad-S792 Ahmad-S792 marked this pull request as ready for review January 18, 2023 01:44
@Ahmad-S792 Ahmad-S792 self-assigned this Jan 18, 2023
@Ahmad-S792 Ahmad-S792 added Media Bugs related to the HTML 5 Media elements. merge-queue Applied to send a pull request to merge-queue labels Jan 18, 2023
Fix duplicate timeupdate events in Text Track Code
https://bugs.webkit.org/show_bug.cgi?id=250741

Reviewed by Eric Carlson.

Merge - https://chromium.googlesource.com/chromium/blink/+/fd62a2259d085146f7fb275f99edb80e0e80243b

This change prevents duplicate timeupdate events caused by the text
track code. The comment above the call indicates that the timeupdate
event should have the same restrictions as the normal periodic
timeupdate event. By changing the parameter passed to
scheduleTimeupdateEvent() to true, the event rate limiting guards
are properly applied to this call and duplicate events won't
fire.

* Source/WebCore/html/HTMLMediaElement.cpp:
(HTMLMediaElement::updateActiveTextTrackCues): Update 'scheduleTimeUpdateEvent' to 'true' to have event rate limit

Canonical link: https://commits.webkit.org/259023@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259023@main (afdf40a): https://commits.webkit.org/259023@main

Reviewed commits have been landed. Closing PR #8745 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit afdf40a into WebKit:main Jan 18, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 18, 2023
@Ahmad-S792 Ahmad-S792 deleted the fix250741-duplicate-timers branch January 18, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Media Bugs related to the HTML 5 Media elements.
Projects
None yet
4 participants