-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CG display list graphics contexts are sometimes still flipped #8810
Merged
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
hortont424:eng/CG-display-list-graphics-contexts-are-sometimes-still-flipped
Jan 19, 2023
Merged
CG display list graphics contexts are sometimes still flipped #8810
webkit-early-warning-system
merged 1 commit into
WebKit:main
from
hortont424:eng/CG-display-list-graphics-contexts-are-sometimes-still-flipped
Jan 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortont424
added
the
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
label
Jan 19, 2023
hortont424
force-pushed
the
eng/CG-display-list-graphics-contexts-are-sometimes-still-flipped
branch
from
January 19, 2023 02:15
3a3af8d
to
4c84f02
Compare
EWS run on previous version of this PR (hash 3a3af8d) |
EWS run on previous version of this PR (hash 4c84f02) |
hortont424
force-pushed
the
eng/CG-display-list-graphics-contexts-are-sometimes-still-flipped
branch
from
January 19, 2023 02:17
4c84f02
to
178d352
Compare
EWS run on current version of this PR (hash 178d352) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 19, 2023
hortont424
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 19, 2023
grorg
approved these changes
Jan 19, 2023
https://bugs.webkit.org/show_bug.cgi?id=250816 rdar://104388673 Reviewed by Dean Jackson. * Source/WebKit/Shared/RemoteLayerTree/CGDisplayListImageBufferBackend.mm: (WebKit::GraphicsContextCGDisplayList::GraphicsContextCGDisplayList): Remove the workaround introduced in r252402@main, since we have reinstated the toplevel context flip in 258997@main. I missed this in 258997@main because it only affects cases where we end up doing setCTM(getCTM()), which is just rare enough to miss with cursory testing. * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.h: * Source/WebKit/Shared/RemoteLayerTree/RemoteLayerBackingStore.mm: (WebKit::RemoteLayerBackingStore::paintContents): (WebKit::RemoteLayerBackingStore::drawInContext): While debugging the above, I also noticed that we were leaving the display list context with a missing trailing `restore` operation, because we encode the display list inside drawInContext. To avoid this, move the flip inside our existing state saver, which is popped before encoding the display list. This has no actual effect at the moment (except making the dumped list look more correct), but will eventually be necessary when the replayed destination context is reused. Canonical link: https://commits.webkit.org/259076@main
webkit-early-warning-system
force-pushed
the
eng/CG-display-list-graphics-contexts-are-sometimes-still-flipped
branch
from
January 19, 2023 11:00
178d352
to
9502f85
Compare
Committed 259076@main (9502f85): https://commits.webkit.org/259076@main Reviewed commits have been landed. Closing PR #8810 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jan 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
WebKit Misc.
For miscellaneous bugs in the WebKit framework (and not JavaScriptCore or WebCore).
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
9502f85
178d352