Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GTK][WPE] Add WPE layout testers for the EWS and two more bots for GTK API test queue #8813

Merged
merged 1 commit into from
Feb 20, 2023
Merged

[GTK][WPE] Add WPE layout testers for the EWS and two more bots for GTK API test queue #8813

merged 1 commit into from
Feb 20, 2023

Conversation

clopez
Copy link
Contributor

@clopez clopez commented Jan 19, 2023 •
edited by webkit-early-warning-system

a61b5a7

[GTK][WPE] Add WPE layout testers for the EWS and two more bots for GTK API test queue
https://bugs.webkit.org/show_bug.cgi?id=250706

Reviewed by Aakash Jain.

We would like to add WPE EWS layout testers for the EWS (new queue) and also two
more testers to the GTK API queue that sometimes is a bit slow.

This are the changes in this patch for the EWS buildbot config:
  - Rename queue 'WPE-EWS' to 'WPE-Build-EWS'
  - And a new queue named: 'WPE-WK2-Tests-EWS' (EWS layout tests) with 8 workers.
  - Add 2 new workers for queue: API-Tests-GTK-EWS
  - Add 1 new worker for queue: WPE-Build-EWS

* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories.py:
(BuildFactory.__init__):
(WPEBuildFactory):
(WPETestsFactory):
(WPEFactory): Deleted.
(WPEFactory.__init__): Deleted.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckChangeRelevance.test_queues_without_relevance_info):

Canonical link: https://commits.webkit.org/260554@main

9bb8d8f

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@clopez clopez self-assigned this Jan 19, 2023
@clopez clopez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 19, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash b69142d)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@clopez clopez requested a review from aperezdc January 19, 2023 16:10
@clopez
Copy link
Contributor Author

clopez commented Feb 11, 2023 •
edited

Patch not longer applies after 3808d46 and 1354cb8
Uploading rebased patch with conflicts fixed.

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9bb8d8f)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 wincairo
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@clopez
Copy link
Contributor Author

clopez commented Feb 11, 2023

Note: the failures on the CI are unrelated to this patch.
See: #9820 (comment)

@clopez clopez added WebKitGTK Bugs related to the Gtk API layer. WPE WebKit WebKit WPE component labels Feb 17, 2023
@clopez clopez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 20, 2023
@clopez
[GTK][WPE] Add WPE layout testers for the EWS and two more bots for G…
a61b5a7 
…TK API test queue

https://bugs.webkit.org/show_bug.cgi?id=250706

Reviewed by Aakash Jain.

We would like to add WPE EWS layout testers for the EWS (new queue) and also two
more testers to the GTK API queue that sometimes is a bit slow.

This are the changes in this patch for the EWS buildbot config:
  - Rename queue 'WPE-EWS' to 'WPE-Build-EWS'
  - And a new queue named: 'WPE-WK2-Tests-EWS' (EWS layout tests) with 8 workers.
  - Add 2 new workers for queue: API-Tests-GTK-EWS
  - Add 1 new worker for queue: WPE-Build-EWS

* Tools/CISupport/ews-build/config.json:
* Tools/CISupport/ews-build/factories.py:
(BuildFactory.__init__):
(WPEBuildFactory):
(WPETestsFactory):
(WPEFactory): Deleted.
(WPEFactory.__init__): Deleted.
* Tools/CISupport/ews-build/factories_unittest.py:
(TestExpectedBuildSteps):
* Tools/CISupport/ews-build/loadConfig.py:
* Tools/CISupport/ews-build/steps_unittest.py:
(TestCheckChangeRelevance.test_queues_without_relevance_info):

Canonical link: https://commits.webkit.org/260554@main
@webkit-commit-queue
Copy link
Collaborator

Committed 260554@main (a61b5a7): https://commits.webkit.org/260554@main

Reviewed commits have been landed. Closing PR #8813 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 20, 2023
@webkit-early-warning-system webkit-early-warning-system merged commit a61b5a7 into WebKit:main Feb 20, 2023
@clopez clopez deleted the bug-250706 branch February 22, 2023 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard left review comments

@aj062 aj062 aj062 approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

@aperezdc aperezdc Awaiting requested review from aperezdc

Assignees

@clopez clopez

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases WebKitGTK Bugs related to the Gtk API layer. WPE WebKit WebKit WPE component
Projects
None yet
Milestone
No milestone
5 participants
@clopez @webkit-early-warning-system @webkit-commit-queue @aj062 @JonWBedard