Delete helper scripts in imported/w3c/web-platform-tests/file-system-access/resources #8846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szewai
added
the
New Bugs
|
EWS run on current version of this PR (hash 7155d91)
|
nt1m
reviewed
Jan 19, 2023
There was a problem hiding this comment.
These files seem to exist upstream: https://github.com/web-platform-tests/wpt/tree/master/file-system-access/resources , are we planning to remove them upstream as well?
Yes, they are unused since web-platform-tests/wpt@5798ab0. |
nt1m
approved these changes
Jan 19, 2023
webkit-commit-queue
force-pushed
the
eng/Delete-helper-scripts-in-importedw3cweb-platform-testsfile-system-accessresources
branch
from
7155d91
to
ec0e959
Compare
…access/resources https://bugs.webkit.org/show_bug.cgi?id=250855 rdar://104437010 Reviewed by Tim Nguyen. The tests that use these scripts were moved to fs/, and these scripts were copied to fs/resources/. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target-dedicated-worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target-service-worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target-shared-worker.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target.html: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/message-target.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/messaging-blob-helpers.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/messaging-helpers.js: Removed. * LayoutTests/imported/w3c/web-platform-tests/file-system-access/resources/messaging-serialize-helpers.js: Removed. Canonical link: https://commits.webkit.org/259120@main
webkit-commit-queue
force-pushed
the
eng/Delete-helper-scripts-in-importedw3cweb-platform-testsfile-system-accessresources
branch
from
ec0e959
to
fe46c0d
Compare
|
Committed 259120@main (fe46c0d): https://commits.webkit.org/259120@main Reviewed commits have been landed. Closing PR #8846 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
wpt pull request: web-platform-tests/wpt#38073 |
szewai
deleted the
eng/Delete-helper-scripts-in-importedw3cweb-platform-testsfile-system-accessresources
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fe46c0d
7155d91
🛠 🧪 win🛠 wincairo🧪 ios-wk2🧪 mac-AS-debug-wk2