Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resync web-platform-tests/resources from upstream #8860

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Resync web-platform-tests/resources from upstream #8860

merged 1 commit into from
Jan 20, 2023

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented Jan 20, 2023 •
edited by webkit-early-warning-system

4a45744

Resync web-platform-tests/resources from upstream
https://bugs.webkit.org/show_bug.cgi?id=250872

Reviewed by Tim Nguyen.

Resync web-platform-tests/resources from upstream d20c3cdbf6e91f14dda92737e.

* LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured-cloning-error-stack-optional.sub.window-expected.txt:
* LayoutTests/imported/w3c/web-platfrom-tests/html/user-activation/*: Updated since they would break otherwise after the resources/ folder re-sync.
* LayoutTests/imported/w3c/web-platform-tests/resources/*: Updated.

Canonical link: https://commits.webkit.org/259143@main

ea21ff2

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez self-assigned this Jan 20, 2023
@cdumez cdumez added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 20, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 9abf331)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ⏳ 🛠 ios ⏳ 🛠 mac ⏳ 🛠 wpe ⏳ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ⏳ 🛠 gtk ⏳ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ⏳ 🧪 api-mac ⏳ 🧪 gtk-wk2
  🧪 api-ios ⏳ 🧪 mac-wk1 ⏳ 🧪 api-gtk
⏳ 🛠 🧪 jsc ⏳ 🛠 tv ⏳ 🧪 mac-wk2
⏳ 🛠 tv-sim   🧪 mac-AS-debug-wk2
⏳ 🛠 watch ⏳ 🧪 mac-wk2-stress
⏳ 🛠 watch-sim

nt1m
nt1m approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@nt1m nt1m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You also synced html/user-activation, might be worth mentioning that in the commit title or splitting that part out.

@cdumez
Copy link
Contributor Author

cdumez commented Jan 20, 2023

You also synced html/user-activation, might be worth mentioning that in the commit title or splitting that part out.

I cannot split it out since the user-activation tests need to be updated to keep working after the resources/ update.

@cdumez cdumez force-pushed the 250872_resync_wpt_resources_jan23 branch from 9abf331 to 6cc1b6e Compare January 20, 2023 00:54
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 6cc1b6e)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 20, 2023
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label Jan 20, 2023
@cdumez cdumez force-pushed the 250872_resync_wpt_resources_jan23 branch from 6cc1b6e to ea21ff2 Compare January 20, 2023 15:30
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ea21ff2)

Misc iOS, tvOS & watchOS macOS Linux Windows
❌ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@cdumez cdumez marked this pull request as ready for review January 20, 2023 16:37
@nt1m
Copy link
Member

nt1m commented Jan 20, 2023

You also synced html/user-activation, might be worth mentioning that in the commit title or splitting that part out.

I cannot split it out since the user-activation tests need to be updated to keep working after the resources/ update.

Worth mentioning in the commit message fwiw.

@cdumez
Copy link
Contributor Author

cdumez commented Jan 20, 2023

You also synced html/user-activation, might be worth mentioning that in the commit title or splitting that part out.

I cannot split it out since the user-activation tests need to be updated to keep working after the resources/ update.

Worth mentioning in the commit message fwiw.

Yes, I already did?

@nt1m
Copy link
Member

nt1m commented Jan 20, 2023

You also synced html/user-activation, might be worth mentioning that in the commit title or splitting that part out.

I cannot split it out since the user-activation tests need to be updated to keep working after the resources/ update.

Worth mentioning in the commit message fwiw.

Yes, I already did?

Ah nevermind, I missed it because it was next to the filename, sorry.

@cdumez cdumez added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 20, 2023
@cdumez
Resync web-platform-tests/resources from upstream
4a45744 
https://bugs.webkit.org/show_bug.cgi?id=250872

Reviewed by Tim Nguyen.

Resync web-platform-tests/resources from upstream d20c3cd.

* LayoutTests/imported/w3c/web-platform-tests/html/infrastructure/safe-passing-of-structured-data/structured-cloning-error-stack-optional.sub.window-expected.txt:
* LayoutTests/imported/w3c/web-platfrom-tests/html/user-activation/*: Updated since they would break otherwise after the resources/ folder re-sync.
* LayoutTests/imported/w3c/web-platform-tests/resources/*: Updated.

Canonical link: https://commits.webkit.org/259143@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259143@main (4a45744): https://commits.webkit.org/259143@main

Reviewed commits have been landed. Closing PR #8860 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 4a45744 into WebKit:main Jan 20, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nt1m nt1m nt1m approved these changes

Assignees

@cdumez cdumez

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@cdumez @webkit-early-warning-system @nt1m @webkit-commit-queue @webkit-ews-buildbot