Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Convert CheckStatusOnEWSQueues to Twisted requests #8865

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 20, 2023

@JonWBedard JonWBedard self-assigned this Jan 20, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 20, 2023
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Convert-CheckStatusOnEWSQueues-to-Twisted-requests branch from c21f805 to 06b5a67 Compare January 24, 2023 23:46
@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 24, 2023
…ests

https://bugs.webkit.org/show_bug.cgi?id=250880
rdar://104454268

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(CheckStatusOnEWSQueues): Convert to new-style.
(CheckStatusOnEWSQueues.get_change_status): Return defered object and use Twisted
asynchronous requests.
(CheckStatusOnEWSQueues.run): Renamed from 'start'.
(CheckStatusOnEWSQueues.start): Renamed to 'run'.

Canonical link: https://commits.webkit.org/259315@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Convert-CheckStatusOnEWSQueues-to-Twisted-requests branch from 06b5a67 to aada344 Compare January 24, 2023 23:50
@webkit-commit-queue
Copy link
Collaborator

Committed 259315@main (aada344): https://commits.webkit.org/259315@main

Reviewed commits have been landed. Closing PR #8865 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit aada344 into WebKit:main Jan 24, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 24, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Convert-CheckStatusOnEWSQueues-to-Twisted-requests branch January 25, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants