Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selector filter fails to collect hash for the first simple selector in :is() #8869

Merged

Conversation

anttijk
Copy link
Contributor

@anttijk anttijk commented Jan 20, 2023

8cee0c8

Selector filter fails to collect hash for the first simple selector in :is()
https://bugs.webkit.org/show_bug.cgi?id=250889
<rdar://problem/104469871>

Reviewed by Alan Baradlay.

Logic bug in https://commits.webkit.org/259089@main

Add testing support for selector filter hash collection and a basic unit test.

* LayoutTests/fast/selectors/selector-filter-hashes-expected.txt: Added.
* LayoutTests/fast/selectors/selector-filter-hashes.html: Added.
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectSelectorHashes):

Collect from the first simple selector too when IncludeRightmost::Yes is set.

(WebCore::SelectorFilter::collectHashesForTesting):
* Source/WebCore/css/SelectorFilter.h:
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::selectorFilterHashCounts):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/259144@main

58f0209

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug ❌ πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac ❌ πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 ❌ πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@anttijk anttijk self-assigned this Jan 20, 2023
@anttijk anttijk added the CSS Cascading Style Sheets implementation label Jan 20, 2023
@anttijk anttijk added the merge-queue Applied to send a pull request to merge-queue label Jan 20, 2023
…n :is()

https://bugs.webkit.org/show_bug.cgi?id=250889
<rdar://problem/104469871>

Reviewed by Alan Baradlay.

Logic bug in https://commits.webkit.org/259089@main

Add testing support for selector filter hash collection and a basic unit test.

* LayoutTests/fast/selectors/selector-filter-hashes-expected.txt: Added.
* LayoutTests/fast/selectors/selector-filter-hashes.html: Added.
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorFilter.cpp:
(WebCore::SelectorFilter::collectSelectorHashes):

Collect from the first simple selector too when IncludeRightmost::Yes is set.

(WebCore::SelectorFilter::collectHashesForTesting):
* Source/WebCore/css/SelectorFilter.h:
* Source/WebCore/css/parser/CSSParser.h:
* Source/WebCore/testing/Internals.cpp:
(WebCore::Internals::selectorFilterHashCounts):
* Source/WebCore/testing/Internals.h:
* Source/WebCore/testing/Internals.idl:

Canonical link: https://commits.webkit.org/259144@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259144@main (8cee0c8): https://commits.webkit.org/259144@main

Reviewed commits have been landed. Closing PR #8869 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 8cee0c8 into WebKit:main Jan 20, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Cascading Style Sheets implementation
Projects
None yet
4 participants