[JSC] Remove Wasm::PinnedRegisterInfo #8900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Constellation
added
the
JavaScriptCore
|
EWS run on previous version of this PR (hash 674bb03) |
Constellation
force-pushed
the
eng/JSC-Remove-WasmPinnedRegisterInfo
branch
from
674bb03
to
d294d0c
Compare
|
EWS run on previous version of this PR (hash d294d0c) |
Constellation
force-pushed
the
eng/JSC-Remove-WasmPinnedRegisterInfo
branch
from
d294d0c
to
99bf8ee
Compare
|
EWS run on previous version of this PR (hash 99bf8ee) |
Constellation
force-pushed
the
eng/JSC-Remove-WasmPinnedRegisterInfo
branch
from
99bf8ee
to
a3d215e
Compare
Constellation
added
the
unsafe-merge-queue
|
EWS run on current version of this PR (hash a3d215e) |
https://bugs.webkit.org/show_bug.cgi?id=250920 rdar://104496000 Reviewed by Mark Lam. This patch removes Wasm::PinnedRegisterInfo since we no longer have TLS version. So, these register information can be defined at compile time. We should just define them in GPRInfo, easy to read what is specified in each architecture. * Source/JavaScriptCore/jit/AssemblyHelpers.cpp: (JSC::AssemblyHelpers::loadWasmContextInstance): (JSC::AssemblyHelpers::storeWasmContextInstance): * Source/JavaScriptCore/jit/GPRInfo.h: * Source/JavaScriptCore/jit/RegisterSet.cpp: (JSC::RegisterSetBuilder::wasmPinnedRegisters): * Source/JavaScriptCore/jit/RegisterSet.h: * Source/JavaScriptCore/wasm/WasmAirIRGeneratorBase.h: (JSC::Wasm::ExpressionType>::AirIRGeneratorBase): (JSC::Wasm::ExpressionType>::restoreWebAssemblyGlobalState): (JSC::Wasm::ExpressionType>::addCall): (JSC::Wasm::ExpressionType>::emitIndirectCall): * Source/JavaScriptCore/wasm/WasmB3IRGenerator.cpp: (JSC::Wasm::B3IRGenerator::B3IRGenerator): (JSC::Wasm::B3IRGenerator::restoreWebAssemblyGlobalState): (JSC::Wasm::B3IRGenerator::emitIndirectCall): (JSC::Wasm::B3IRGenerator::addCall): * Source/JavaScriptCore/wasm/WasmBinding.cpp: (JSC::Wasm::wasmToWasm): * Source/JavaScriptCore/wasm/WasmMemoryInformation.cpp: (JSC::Wasm::PinnedRegisterInfo::get): Deleted. (JSC::Wasm::PinnedRegisterInfo::PinnedRegisterInfo): Deleted. * Source/JavaScriptCore/wasm/WasmMemoryInformation.h: (JSC::Wasm::PinnedRegisterInfo::toSave const): Deleted. * Source/JavaScriptCore/wasm/WasmOperations.cpp: (JSC::Wasm::JSC_DEFINE_JIT_OPERATION): * Source/JavaScriptCore/wasm/js/JSToWasm.cpp: (JSC::Wasm::marshallJSResult): (JSC::Wasm::createJSToWasmWrapper): * Source/JavaScriptCore/wasm/js/WasmToJS.cpp: (JSC::Wasm::materializeImportJSCell): (JSC::Wasm::wasmToJS): * Source/JavaScriptCore/wasm/js/WebAssemblyFunction.cpp: (JSC::WebAssemblyFunction::calleeSaves const): (JSC::WebAssemblyFunction::jsCallEntrypointSlow): Canonical link: https://commits.webkit.org/259161@main
webkit-early-warning-system
force-pushed
the
eng/JSC-Remove-WasmPinnedRegisterInfo
branch
from
a3d215e
to
4dae653
Compare
|
Committed 259161@main (4dae653): https://commits.webkit.org/259161@main Reviewed commits have been landed. Closing PR #8900 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4dae653
a3d215e
🛠 mac🛠 🧪 win🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🛠 🧪 jsc🛠 tv🧪 mac-wk2🛠 🧪 jsc-arm64🧪 mac-AS-debug-wk2🧪 jsc-armv7-tests🧪 mac-wk2-stress🧪 jsc-mips-tests