Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misc compiler warnings, January 2023 edition #8928

Conversation

mcatanzaro
Copy link
Contributor

@mcatanzaro mcatanzaro commented Jan 21, 2023

0b614af

Fix misc compiler warnings, January 2023 edition
https://bugs.webkit.org/show_bug.cgi?id=250945

Reviewed by Philippe Normand.

It's been a long time since my last round of warning fixes, since
warnings on EWS are fatal now, which is saving me a lot of effort. But
today I decided to try building with Clang instead of GCC, and it found
some problems that GCC misses.

* Source/JavaScriptCore/ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):
* Source/ThirdParty/xdgmime/CMakeLists.txt:
* Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.h:
* Source/WebCore/platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::timeToSampleFrame):
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseTakeViewSnapshot):
* Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::snapshot):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:
(webkitFrameGetJSCValuesForElementsInWorld):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

Canonical link: https://commits.webkit.org/259183@main

2c00ff3

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
❌ πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@mcatanzaro mcatanzaro self-assigned this Jan 21, 2023
@mcatanzaro mcatanzaro added the WebKitGTK Bugs related to the Gtk API layer. label Jan 21, 2023
@mcatanzaro mcatanzaro added the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2023
https://bugs.webkit.org/show_bug.cgi?id=250945

Reviewed by Philippe Normand.

It's been a long time since my last round of warning fixes, since
warnings on EWS are fatal now, which is saving me a lot of effort. But
today I decided to try building with Clang instead of GCC, and it found
some problems that GCC misses.

* Source/JavaScriptCore/ftl/FTLOperations.cpp:
(JSC::FTL::JSC_DEFINE_JIT_OPERATION):
* Source/ThirdParty/xdgmime/CMakeLists.txt:
* Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.h:
* Source/WebCore/platform/audio/AudioUtilities.cpp:
(WebCore::AudioUtilities::timeToSampleFrame):
* Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseTakeViewSnapshot):
* Source/WebKit/UIProcess/gtk/ViewGestureControllerGtk.cpp:
(WebKit::ViewGestureController::beginSwipeGesture):
(WebKit::ViewGestureController::snapshot):
* Source/WebKit/WebProcess/InjectedBundle/API/glib/WebKitFrame.cpp:
(webkitFrameGetJSCValuesForElementsInWorld):
* Tools/TestWebKitAPI/Tests/WebKitGtk/TestContextMenu.cpp:

Canonical link: https://commits.webkit.org/259183@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Fix-misc-compiler-warnings-January-2023-edition branch from 2c00ff3 to 0b614af Compare January 22, 2023 15:36
@webkit-commit-queue
Copy link
Collaborator

Committed 259183@main (0b614af): https://commits.webkit.org/259183@main

Reviewed commits have been landed. Closing PR #8928 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 0b614af into WebKit:main Jan 22, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKitGTK Bugs related to the Gtk API layer.
Projects
None yet
4 participants