[css-ui] Hide input[type=search] icons when appearance: textfield is set

[nt1m]

d08a6f7

[css-ui] Hide input[type=search] icons when appearance: textfield is set
https://bugs.webkit.org/show_bug.cgi?id=238751
<rdar://91253463>

Reviewed by Aditya Keerthi and Antti Koivisto.

This forces the display value to none when appearance: textfield is set to make it look like input[type=text], matching the CSS UI spec.

There are however still two issues in order to make input[type=search] match input[type=text] fully with appearance: textfield:
- iOS has special UA styles in html.css that need to stop applying with appearance: textfield
- The focus outline offset is inflated on macOS (although this is an issue with other contexts too), see webkit.org/b/241102

* LayoutTests/TestExpectations:
* LayoutTests/fast/forms/search/search-padding-cancel-results-buttons.html:
* LayoutTests/platform/ios/TestExpectations:
* LayoutTests/platform/ios/fast/css/input-search-padding-expected.txt:
* LayoutTests/platform/gtk/fast/css/input-search-padding-expected.png:
* LayoutTests/platform/gtk/fast/css/input-search-padding-expected.txt:
* Source/WebCore/html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldResultsButtonElement::resolveCustomStyle):
(WebCore::SearchFieldCancelButtonElement::resolveCustomStyle):

Canonical link: https://commits.webkit.org/253691@main

71290c1

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
	❌ 🛠 ios-sim	🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	❌ 🛠 watch	🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

[webkit-early-warning-system]

EWS run on previous version of this PR (hash c223da5)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	❌ 🛠 mac	❌ 🛠 wpe
	❌ 🛠 ios-sim	⏳ 🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	❌ 🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	⏳ 🛠 tv	❌ 🧪 mac-wk1	❌ 🛠 jsc-armv7
	⏳ 🛠 tv-sim	❌ 🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	⏳ 🛠 watch-sim	❌ 🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 7389368)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	🧪 ios-wk2	⏳ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	🧪 api-ios	🧪 api-mac	🧪 api-gtk
	⏳ 🛠 tv	🧪 mac-wk1
	⏳ 🛠 tv-sim	✅ 🧪 mac-wk2
	⏳ 🛠 watch	⏳ 🧪 mac-AS-debug-wk2
	⏳ 🛠 watch-sim	🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash a6d08bf)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	❌ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	🧪 api-ios	🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

EWS run on previous version of this PR (hash 98c8ab0)

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
✅ 🧪 style	✅ 🛠 ios	✅ 🛠 mac	✅ 🛠 wpe	✅ 🛠 🧪 win
✅ 🧪 bindings	✅ 🛠 ios-sim	✅ 🛠 mac-debug	✅ 🛠 gtk	✅ 🛠 wincairo
✅ 🧪 webkitperl	✅ 🧪 ios-wk2	✅ 🛠 mac-AS-debug	✅ 🧪 gtk-wk2
	✅ 🧪 api-ios	✅ 🧪 api-mac	✅ 🧪 api-gtk
	✅ 🛠 tv	✅ 🧪 mac-wk1
	✅ 🛠 tv-sim	✅ 🧪 mac-wk2
	✅ 🛠 watch	✅ 🧪 mac-AS-debug-wk2
	✅ 🛠 watch-sim	✅ 🧪 mac-wk2-stress

[webkit-early-warning-system]

71290c1

Misc	iOS, tvOS & watchOS	macOS	Linux	Windows
❌ 🧪 style	❌ 🛠 ios	🛠 mac	❌ 🛠 wpe	❌ 🛠 🧪 win
	❌ 🛠 ios-sim	🛠 mac-debug	❌ 🛠 gtk	❌ 🛠 wincairo
❌ 🧪 webkitperl	❌ 🧪 ios-wk2	🛠 mac-AS-debug	❌ 🧪 gtk-wk2
	❌ 🧪 api-ios	🧪 api-mac	❌ 🧪 api-gtk
❌ 🛠 🧪 jsc	❌ 🛠 tv	🧪 mac-wk1	❌ 🛠 jsc-armv7
	❌ 🛠 tv-sim	🧪 mac-wk2	❌ 🧪 jsc-armv7-tests
✅ 🛠 🧪 merge	❌ 🛠 watch	🧪 mac-AS-debug-wk2	❌ 🛠 jsc-mips
	❌ 🛠 watch-sim	🧪 mac-wk2-stress	❌ 🧪 jsc-mips-tests

[webkit-commit-queue]

Committed 253691@main (d08a6f7): https://commits.webkit.org/253691@main

Reviewed commits have been landed. Closing PR #895 and removing active labels.