Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port the remaining editing related types to the new serialization format #8994

Conversation

gavin-apple
Copy link
Contributor

@gavin-apple gavin-apple commented Jan 23, 2023

761e29f

Port the remaining editing related types to the new serialization format
https://bugs.webkit.org/show_bug.cgi?id=251025
rdar://104574856

Reviewed by Ryosuke Niwa.

This change ports the remaining editing base types to the new serialization
format. This includes:
    - FontShadow
    - CompositionHighlight
    - FontChanges
    - FontAttributeChanges
    - TextManipulationControllerExclusionRule
    - TextManipulationControllerExclusionRule::Type
    - TextManipulationControllerExclusionRule::ElementRule
    - TextManipulationControllerExclusionRule::AttributeRule
    - TextManipulationControllerExclusionRule::ClassRule
    - TextManipulationControllerManipulationFailure
    - TextManipulationControllerManipulationFailure::Type

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/CompositionHighlight.h:
(WebCore::CompositionHighlight::encode const): Deleted.
(WebCore::CompositionHighlight::decode): Deleted.
* Source/WebCore/editing/FontAttributeChanges.cpp:
(WebCore::FontChanges::FontChanges):
(WebCore::FontAttributeChanges::FontAttributeChanges):
* Source/WebCore/editing/FontAttributeChanges.h:
(WebCore::FontChanges::encode const): Deleted.
(WebCore::FontChanges::decode): Deleted.
(WebCore::FontAttributeChanges::encode const): Deleted.
(WebCore::FontAttributeChanges::decode): Deleted.
* Source/WebCore/editing/FontAttributes.h:
* Source/WebCore/editing/FontShadow.h:
(WebCore::FontShadow::encode const): Deleted.
(WebCore::FontShadow::decode): Deleted.
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationControllerExclusionRule::match const):
(WebCore::TextManipulationController::completeManipulation):
(WebCore::TextManipulationController::replace):
(WebCore::TextManipulationController::ExclusionRule::match const): Deleted.
* Source/WebCore/editing/TextManipulationController.h:
(WebCore::TextManipulationController::startObservingParagraphs):
(WebCore::TextManipulationController::ExclusionRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ClassRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ClassRule::decode): Deleted.
(WebCore::TextManipulationController::ManipulationFailure::encode const): Deleted.
(WebCore::TextManipulationController::ManipulationFailure::decode): Deleted.
* Source/WebCore/editing/TextManipulationControllerExclusionRule.h: Copied from Source/WebCore/editing/FontShadow.h.
* Source/WebCore/editing/TextManipulationControllerManipulationFailure.h: Copied from Source/WebCore/editing/FontShadow.h.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259302@main

861671a

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim βœ… πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@gavin-apple gavin-apple self-assigned this Jan 23, 2023
@gavin-apple gavin-apple added the WebKit Process Model Bugs related to WebKit's multi-process architecture label Jan 23, 2023
@rniwa rniwa requested a review from whsieh January 23, 2023 23:03
Copy link
Member

@rniwa rniwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane to me.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 23, 2023
@gavin-apple gavin-apple force-pushed the eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format branch from eb59e23 to 861671a Compare January 24, 2023 13:59
@gavin-apple gavin-apple added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels Jan 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=251025
rdar://104574856

Reviewed by Ryosuke Niwa.

This change ports the remaining editing base types to the new serialization
format. This includes:
    - FontShadow
    - CompositionHighlight
    - FontChanges
    - FontAttributeChanges
    - TextManipulationControllerExclusionRule
    - TextManipulationControllerExclusionRule::Type
    - TextManipulationControllerExclusionRule::ElementRule
    - TextManipulationControllerExclusionRule::AttributeRule
    - TextManipulationControllerExclusionRule::ClassRule
    - TextManipulationControllerManipulationFailure
    - TextManipulationControllerManipulationFailure::Type

* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/editing/CompositionHighlight.h:
(WebCore::CompositionHighlight::encode const): Deleted.
(WebCore::CompositionHighlight::decode): Deleted.
* Source/WebCore/editing/FontAttributeChanges.cpp:
(WebCore::FontChanges::FontChanges):
(WebCore::FontAttributeChanges::FontAttributeChanges):
* Source/WebCore/editing/FontAttributeChanges.h:
(WebCore::FontChanges::encode const): Deleted.
(WebCore::FontChanges::decode): Deleted.
(WebCore::FontAttributeChanges::encode const): Deleted.
(WebCore::FontAttributeChanges::decode): Deleted.
* Source/WebCore/editing/FontAttributes.h:
* Source/WebCore/editing/FontShadow.h:
(WebCore::FontShadow::encode const): Deleted.
(WebCore::FontShadow::decode): Deleted.
* Source/WebCore/editing/TextManipulationController.cpp:
(WebCore::TextManipulationControllerExclusionRule::match const):
(WebCore::TextManipulationController::completeManipulation):
(WebCore::TextManipulationController::replace):
(WebCore::TextManipulationController::ExclusionRule::match const): Deleted.
* Source/WebCore/editing/TextManipulationController.h:
(WebCore::TextManipulationController::startObservingParagraphs):
(WebCore::TextManipulationController::ExclusionRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ClassRule::encode const): Deleted.
(WebCore::TextManipulationController::ExclusionRule::ClassRule::decode): Deleted.
(WebCore::TextManipulationController::ManipulationFailure::encode const): Deleted.
(WebCore::TextManipulationController::ManipulationFailure::decode): Deleted.
* Source/WebCore/editing/TextManipulationControllerExclusionRule.h: Copied from Source/WebCore/editing/FontShadow.h.
* Source/WebCore/editing/TextManipulationControllerManipulationFailure.h: Copied from Source/WebCore/editing/FontShadow.h.
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/259302@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format branch from 861671a to 761e29f Compare January 24, 2023 20:13
@webkit-commit-queue
Copy link
Collaborator

Committed 259302@main (761e29f): https://commits.webkit.org/259302@main

Reviewed commits have been landed. Closing PR #8994 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 761e29f into WebKit:main Jan 24, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WebKit Process Model Bugs related to WebKit's multi-process architecture
Projects
None yet
5 participants