-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port the remaining editing related types to the new serialization format #8994
Merged
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gavin-apple:eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format
Jan 24, 2023
Merged
Port the remaining editing related types to the new serialization format #8994
webkit-commit-queue
merged 1 commit into
WebKit:main
from
gavin-apple:eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format
Jan 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavin-apple
added
the
WebKit Process Model
Bugs related to WebKit's multi-process architecture
label
Jan 23, 2023
EWS run on previous version of this PR (hash eb59e23) |
rniwa
approved these changes
Jan 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks sane to me.
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 23, 2023
gavin-apple
force-pushed
the
eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format
branch
from
January 24, 2023 13:59
eb59e23
to
861671a
Compare
EWS run on current version of this PR (hash 861671a) |
gavin-apple
added
merge-queue
Applied to send a pull request to merge-queue
and removed
merging-blocked
Applied to prevent a change from being merged
labels
Jan 24, 2023
https://bugs.webkit.org/show_bug.cgi?id=251025 rdar://104574856 Reviewed by Ryosuke Niwa. This change ports the remaining editing base types to the new serialization format. This includes: - FontShadow - CompositionHighlight - FontChanges - FontAttributeChanges - TextManipulationControllerExclusionRule - TextManipulationControllerExclusionRule::Type - TextManipulationControllerExclusionRule::ElementRule - TextManipulationControllerExclusionRule::AttributeRule - TextManipulationControllerExclusionRule::ClassRule - TextManipulationControllerManipulationFailure - TextManipulationControllerManipulationFailure::Type * Source/WebCore/WebCore.xcodeproj/project.pbxproj: * Source/WebCore/editing/CompositionHighlight.h: (WebCore::CompositionHighlight::encode const): Deleted. (WebCore::CompositionHighlight::decode): Deleted. * Source/WebCore/editing/FontAttributeChanges.cpp: (WebCore::FontChanges::FontChanges): (WebCore::FontAttributeChanges::FontAttributeChanges): * Source/WebCore/editing/FontAttributeChanges.h: (WebCore::FontChanges::encode const): Deleted. (WebCore::FontChanges::decode): Deleted. (WebCore::FontAttributeChanges::encode const): Deleted. (WebCore::FontAttributeChanges::decode): Deleted. * Source/WebCore/editing/FontAttributes.h: * Source/WebCore/editing/FontShadow.h: (WebCore::FontShadow::encode const): Deleted. (WebCore::FontShadow::decode): Deleted. * Source/WebCore/editing/TextManipulationController.cpp: (WebCore::TextManipulationControllerExclusionRule::match const): (WebCore::TextManipulationController::completeManipulation): (WebCore::TextManipulationController::replace): (WebCore::TextManipulationController::ExclusionRule::match const): Deleted. * Source/WebCore/editing/TextManipulationController.h: (WebCore::TextManipulationController::startObservingParagraphs): (WebCore::TextManipulationController::ExclusionRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::ElementRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::ElementRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::AttributeRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::AttributeRule::decode): Deleted. (WebCore::TextManipulationController::ExclusionRule::ClassRule::encode const): Deleted. (WebCore::TextManipulationController::ExclusionRule::ClassRule::decode): Deleted. (WebCore::TextManipulationController::ManipulationFailure::encode const): Deleted. (WebCore::TextManipulationController::ManipulationFailure::decode): Deleted. * Source/WebCore/editing/TextManipulationControllerExclusionRule.h: Copied from Source/WebCore/editing/FontShadow.h. * Source/WebCore/editing/TextManipulationControllerManipulationFailure.h: Copied from Source/WebCore/editing/FontShadow.h. * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: Canonical link: https://commits.webkit.org/259302@main
webkit-commit-queue
force-pushed
the
eng/Port-the-remaining-editing-related-types-to-the-new-serialization-format
branch
from
January 24, 2023 20:13
861671a
to
761e29f
Compare
Committed 259302@main (761e29f): https://commits.webkit.org/259302@main Reviewed commits have been landed. Closing PR #8994 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
761e29f
861671a