[macOS] Fix sandbox related error message #9052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvollan
added
the
WebKit Misc.
|
EWS run on current version of this PR (hash 266f30a) |
cdumez
reviewed
Jan 24, 2023
| @@ -1389,7 +1389,7 @@ | |||
| #endif | |||
| #endif | |||
|
|
|||
| #if (PLATFORM(IOS) || PLATFORM(WATCHOS) || PLATFORM(APPLETV)) | |||
There was a problem hiding this comment.
So we don't want to enable this for Watch or TV anymore?
There was a problem hiding this comment.
Yes, I would like to do more testing before enabling.
Thanks for reviewing!
cdumez
approved these changes
Jan 24, 2023
pvollan
added
the
unsafe-merge-queue
https://bugs.webkit.org/show_bug.cgi?id=251093 rdar://104607120 Reviewed by Chris Dumez. On macOS, creating a generic Mach bootstrap sandbox extension is currently failing. We can temporarily disable creating this sandbox extension on macOS. * Source/WTF/wtf/PlatformHave.h: * Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in: * Source/WebKit/Shared/Cocoa/SandboxExtensionCocoa.mm: (WebKit::SandboxExtension::createHandlesForMachLookup): Canonical link: https://commits.webkit.org/259313@main
webkit-early-warning-system
force-pushed
the
eng/macOS-Fix-sandbox-related-error-message
branch
from
266f30a
to
7e8a23f
Compare
|
Committed 259313@main (7e8a23f): https://commits.webkit.org/259313@main Reviewed commits have been landed. Closing PR #9052 and removing active labels. |
webkit-commit-queue
removed
the
unsafe-merge-queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
7e8a23f
266f30a
🧪 mac-AS-debug-wk2