Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Inspector: Embedder settings are not being persisted, preventing Web Inspector from remembering which side of the window it was attached to #9070

Conversation

patrickangle
Copy link
Contributor

@patrickangle patrickangle commented Jan 24, 2023

@patrickangle patrickangle self-assigned this Jan 24, 2023
@patrickangle patrickangle added the Web Inspector Bugs related to the WebKit Web Inspector. label Jan 24, 2023
Copy link
Contributor

@brentfulgham brentfulgham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry we broke this! r=me.

@patrickangle patrickangle added the merge-queue Applied to send a pull request to merge-queue label Jan 24, 2023
…Web Inspector from remembering which side of the window it was attached to

https://bugs.webkit.org/show_bug.cgi?id=251110
rdar://104603328

Reviewed by Brent Fulgham and Elliott Williams.

Embedder settings should persist to restore behavior prior to 258448@main. This allows Web Inspector to load
its width/height/attached side/window state from defaults like before.

* Source/WTF/Scripts/GeneratePreferences.rb:

Canonical link: https://commits.webkit.org/259320@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Web-Inspector-Embedder-settings-are-not-being-persisted-preventing-Web-Inspector-from-remembering-which-side-of-the-window-it-was-attached-to branch from ab64398 to 827706a Compare January 25, 2023 01:06
@webkit-early-warning-system webkit-early-warning-system merged commit 827706a into WebKit:main Jan 25, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 259320@main (827706a): https://commits.webkit.org/259320@main

Reviewed commits have been landed. Closing PR #9070 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Web Inspector Bugs related to the WebKit Web Inspector.
Projects
None yet
5 participants