Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews-build.webkit.org] Convert ValidateChange to new-style buildstep #9083

Merged
merged 1 commit into from
Jan 25, 2023
Merged

[ews-build.webkit.org] Convert ValidateChange to new-style buildstep #9083

merged 1 commit into from
Jan 25, 2023

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 25, 2023 •
edited by webkit-early-warning-system

924d38d

[ews-build.webkit.org] Convert ValidateChange to new-style buildstep
https://bugs.webkit.org/show_bug.cgi?id=251125
rdar://104625110

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(ValidateChange.skip_build): Return step status, wait on _addToLog.
(ValidateChange.fail_build): Ditto.
(ValidateChange.run): Renamed from start, return step status.
(ValidateChange.validate_bugzilla): Return step status.
(ValidateChange.validate_github): Ditto.
(ValidateChange.start): Renamed to run.

Canonical link: https://commits.webkit.org/259379@main

b8dcba0

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
  🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
  🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim   🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@JonWBedard JonWBedard self-assigned this Jan 25, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 25, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on previous version of this PR (hash 832c2ac)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
❌ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 🧪 jsc ✅ 🛠 tv ❌ 🧪 mac-wk2 ✅ 🛠 jsc-armv7
✅ 🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim ✅ 🧪 jsc-mips-tests

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 25, 2023
aj062
aj062 approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested.

@JonWBedard JonWBedard removed the merging-blocked Applied to prevent a change from being merged label Jan 25, 2023
@JonWBedard JonWBedard force-pushed the eng/ews-build-webkit-org-Convert-ValidateChange-to-new-style-buildstep branch from 832c2ac to b8dcba0 Compare January 25, 2023 17:39
@JonWBedard
Copy link
Member Author

r+ assuming this is tested.

Verified in the UAT instance, you can see it working on things like https://ews-build.webkit-uat.org/#/builders/4/builds/3288

@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b8dcba0)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2 ✅ 🧪 api-mac   🧪 gtk-wk2
✅ 🧪 webkitpy ✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
  🛠 🧪 jsc ✅ 🛠 tv   🧪 mac-wk2 ✅ 🛠 jsc-armv7
  🛠 🧪 jsc-arm64 ✅ 🛠 tv-sim ✅ 🧪 mac-AS-debug-wk2 ✅ 🧪 jsc-armv7-tests
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress ✅ 🛠 jsc-mips
✅ 🛠 watch-sim   🧪 jsc-mips-tests
✅ 🛠 🧪 unsafe-merge

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2023
@JonWBedard
[ews-build.webkit.org] Convert ValidateChange to new-style buildstep
924d38d 
https://bugs.webkit.org/show_bug.cgi?id=251125
rdar://104625110

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(ValidateChange.skip_build): Return step status, wait on _addToLog.
(ValidateChange.fail_build): Ditto.
(ValidateChange.run): Renamed from start, return step status.
(ValidateChange.validate_bugzilla): Return step status.
(ValidateChange.validate_github): Ditto.
(ValidateChange.start): Renamed to run.

Canonical link: https://commits.webkit.org/259379@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Convert-ValidateChange-to-new-style-buildstep branch from b8dcba0 to 924d38d Compare January 25, 2023 19:59
@webkit-commit-queue
Copy link
Collaborator

Committed 259379@main (924d38d): https://commits.webkit.org/259379@main

Reviewed commits have been landed. Closing PR #9083 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 924d38d into WebKit:main Jan 25, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 25, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Convert-ValidateChange-to-new-style-buildstep branch January 26, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@JonWBedard @webkit-early-warning-system @webkit-commit-queue @aj062 @webkit-ews-buildbot