-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using a = b in *.serialization.in files #9127
Allow using a = b in *.serialization.in files #9127
Conversation
d80add1
to
5823253
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is nicer I think.
Note that the previous serialization logic didn't even need this typedef/alias iirc. This is better than rewriting the typedef as a struct but ideally we wouldn't even need this alias in the serialization.in and we'd let the generated code figure out that SharedStringHash is a typedef to uint32_t simply by including the SharedStringHash.h header. |
I don't think that's possible until C++ reflection becomes part of the language. The metadata needs to be strings "WebCore::SharedStringHash" and "uint32_t". Until then, I think this is the minimum amount of metadata needed. |
https://bugs.webkit.org/show_bug.cgi?id=251160 Reviewed by Chris Dumez. This fixes a shortcut I took in 259180@main. Expose the information to the IPC testing API as if b contained a, which is equivalent from the point of view of serialization. No actual serializers need to be generated. * Source/WebKit/Scripts/generate-serializers.py: (generate_serialized_type_info): (generate_serialized_type_info.in): (parse_serialized_types): (main): (main.in): * Source/WebKit/Scripts/webkit/tests/SerializedTypeInfo.cpp: (WebKit::allSerializedTypes): * Source/WebKit/Scripts/webkit/tests/TestSerializedType.serialization.in: * Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in: * Source/WebKit/UIProcess/VisitedLinkStore.messages.in: * Source/WebKit/WebProcess/WebPage/VisitedLinkTableController.messages.in: Canonical link: https://commits.webkit.org/259383@main
5823253
to
e7b14b5
Compare
Committed 259383@main (e7b14b5): https://commits.webkit.org/259383@main Reviewed commits have been landed. Closing PR #9127 and removing active labels. |
EWS run on current version of this PR (hash 5823253)
|
e7b14b5
5823253
π iosπ macπ wpeπ π§ͺ winπ§ͺ bindingsπ ios-simπ mac-AS-debugπ gtkπ wincairoπ§ͺ ios-wk2π§ͺ api-macπ§ͺ gtk-wk2π§ͺ webkitpyπ§ͺ api-iosπ§ͺ mac-wk1π§ͺ api-gtkπ π§ͺ jscπ tvπ§ͺ mac-wk2π jsc-armv7π π§ͺ jsc-arm64π tv-simπ§ͺ mac-AS-debug-wk2π§ͺ jsc-armv7-testsπ§ͺ servicesπ watchπ§ͺ mac-wk2-stressπ watch-simπ§ͺ jsc-mips-tests