Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove RenderSliderThumb #913

Merged
merged 0 commits into from May 24, 2022
Merged

Remove RenderSliderThumb #913

merged 0 commits into from May 24, 2022

Conversation

nt1m
Copy link
Member

@nt1m nt1m commented May 23, 2022 •
edited by webkit-early-warning-system

0f3a1e2

Remove RenderSliderThumb
https://bugs.webkit.org/show_bug.cgi?id=240794

Reviewed by Antti Koivisto.

Test: imported/w3c/web-platform-tests/css/css-ui/appearance-cssom-001.html

* Source/WebCore/html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::resolveCustomStyle):
(WebCore::SliderContainerElement::resolveCustomStyle):
(WebCore::RenderSliderThumb::RenderSliderThumb): Deleted.
(WebCore::RenderSliderThumb::updateAppearance): Deleted.
(WebCore::RenderSliderThumb::isSliderThumb const): Deleted.
(WebCore::SliderThumbElement::createElementRenderer): Deleted.
* Source/WebCore/html/shadow/SliderThumbElement.h:
* Source/WebCore/rendering/RenderObject.h:
(WebCore::RenderObject::isSlider const):
(WebCore::RenderObject::isSliderThumb const): Deleted.
* Source/WebCore/rendering/RenderSlider.cpp:
(WebCore::RenderSlider::layout): Deleted.
* Source/WebCore/rendering/RenderSlider.h:

Canonical link: https://commits.webkit.org/250906@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@nt1m nt1m self-assigned this May 23, 2022
@nt1m nt1m added Layout and Rendering For bugs with layout and rendering of Web pages. WebKit Nightly Build labels May 23, 2022
@nt1m nt1m requested review from anttijk and pxlcoder May 23, 2022 14:32
@nt1m nt1m requested a review from alanbaradlay May 23, 2022 15:34
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 23, 2022
@nt1m nt1m marked this pull request as draft May 23, 2022 17:50
@nt1m nt1m removed merging-blocked Applied to prevent a change from being merged Layout and Rendering For bugs with layout and rendering of Web pages. WebKit Nightly Build labels May 23, 2022
@nt1m nt1m changed the title [css-ui] Remove RenderSliderThumb and unexpose related CSS appearance values Remove RenderSliderThumb May 23, 2022
@nt1m nt1m added Layout and Rendering For bugs with layout and rendering of Web pages. WebKit Nightly Build labels May 23, 2022
@nt1m nt1m marked this pull request as ready for review May 23, 2022 20:51
@nt1m nt1m force-pushed the slider-thumb branch 2 times, most recently from c1c6e90 to dd1e476 Compare May 23, 2022 21:38
@nt1m nt1m added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 0f3a1e2 into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294728 (250906@main): https://commits.webkit.org/250906@main

Reviewed commits have been landed. Closing PR #913 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label May 24, 2022
@nt1m nt1m deleted the slider-thumb branch May 24, 2022 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anttijk anttijk anttijk approved these changes

@pxlcoder pxlcoder Awaiting requested review from pxlcoder

@alanbaradlay alanbaradlay Awaiting requested review from alanbaradlay

Assignees

@nt1m nt1m

Labels
Layout and Rendering For bugs with layout and rendering of Web pages.
Projects
None yet
Milestone
No milestone
3 participants
@nt1m @webkit-early-warning-system @anttijk