Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merge-Queue] Check for 'Unreviewed test gardening' string should be case insensitive #9181

Merged
merged 1 commit into from
Jan 26, 2023
Merged

[Merge-Queue] Check for 'Unreviewed test gardening' string should be case insensitive #9181

merged 1 commit into from
Jan 26, 2023

Conversation

ryanhaddad
Copy link
Contributor

@ryanhaddad ryanhaddad commented Jan 26, 2023 •
edited by webkit-early-warning-system

0c7c5a3

[Merge-Queue] Check for 'Unreviewed test gardening' string should be case insensitive
https://bugs.webkit.org/show_bug.cgi?id=251215
rdar://104700375

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(UpdatePullRequest.is_test_gardening):

Canonical link: https://commits.webkit.org/259447@main

ca94090

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@ryanhaddad ryanhaddad self-assigned this Jan 26, 2023
@ryanhaddad ryanhaddad added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 26, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ca94090)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe   🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk   🛠 wincairo
✅ 🧪 webkitperl   🧪 ios-wk2   🧪 api-mac   🧪 gtk-wk2
  🧪 api-ios   🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv   🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch   🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@ryanhaddad ryanhaddad added the skip-ews Applied to prevent a change from being run on EWS label Jan 26, 2023
@ryanhaddad ryanhaddad added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing skip-ews Applied to prevent a change from being run on EWS labels Jan 26, 2023
@ryanhaddad
[Merge-Queue] Check for 'Unreviewed test gardening' string should be …
0c7c5a3 
…case insensitive

https://bugs.webkit.org/show_bug.cgi?id=251215
rdar://104700375

Reviewed by Jonathan Bedard.

* Tools/CISupport/ews-build/steps.py:
(UpdatePullRequest.is_test_gardening):

Canonical link: https://commits.webkit.org/259447@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Merge-Queue-Check-for-Unreviewed-test-gardening-string-should-be-case-insensitive branch from ca94090 to 0c7c5a3 Compare January 26, 2023 19:54
@webkit-commit-queue
Copy link
Collaborator

Committed 259447@main (0c7c5a3): https://commits.webkit.org/259447@main

Reviewed commits have been landed. Closing PR #9181 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 0c7c5a3 into WebKit:main Jan 26, 2023
@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JonWBedard JonWBedard JonWBedard approved these changes

@aj062 aj062 Awaiting requested review from aj062 aj062 is a code owner

Assignees

@ryanhaddad ryanhaddad

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
4 participants
@ryanhaddad @webkit-early-warning-system @webkit-commit-queue @JonWBedard