Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ews-build.webkit.org] Convert AnalyzeAPITestsResults to new-style buildstep #9193

Merged
merged 1 commit into from
Jan 28, 2023
Merged

[ews-build.webkit.org] Convert AnalyzeAPITestsResults to new-style buildstep #9193

merged 1 commit into from
Jan 28, 2023

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 27, 2023 •
edited by webkit-early-warning-system

ca0fcb9

[ews-build.webkit.org] Convert AnalyzeAPITestsResults to new-style buildstep
https://bugs.webkit.org/show_bug.cgi?id=251230
rdar://104718250

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeAPITestsResults):
(AnalyzeAPITestsResults.run): Renamed from start.
(AnalyzeAPITestsResults.analyzeResults): Make entire function asynchronous, since it calls
asynchronous functions.
(AnalyzeAPITestsResults.getTestsResults): Correctly yield log additions.
(AnalyzeAPITestsResults.start): Renamed to run.

Canonical link: https://commits.webkit.org/259526@main

ba47870

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

@JonWBedard JonWBedard self-assigned this Jan 27, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 27, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash ba47870)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1 ✅ 🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🧪 services ✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim
✅ 🛠 🧪 unsafe-merge

aj062
aj062 approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested.

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 27, 2023
@JonWBedard
Copy link
Member Author

https://ews-build.webkit-uat.org/#/builders/26/builds/4 is a full test of this.

@JonWBedard JonWBedard added unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing and removed merging-blocked Applied to prevent a change from being merged labels Jan 28, 2023
@JonWBedard
[ews-build.webkit.org] Convert AnalyzeAPITestsResults to new-style bu…
ca0fcb9 
…ildstep

https://bugs.webkit.org/show_bug.cgi?id=251230
rdar://104718250

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeAPITestsResults):
(AnalyzeAPITestsResults.run): Renamed from start.
(AnalyzeAPITestsResults.analyzeResults): Make entire function asynchronous, since it calls
asynchronous functions.
(AnalyzeAPITestsResults.getTestsResults): Correctly yield log additions.
(AnalyzeAPITestsResults.start): Renamed to run.

Canonical link: https://commits.webkit.org/259526@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Convert-AnalyzeAPITestsResults-to-new-style-buildstep branch from ba47870 to ca0fcb9 Compare January 28, 2023 15:56
@webkit-early-warning-system webkit-early-warning-system merged commit ca0fcb9 into WebKit:main Jan 28, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 259526@main (ca0fcb9): https://commits.webkit.org/259526@main

Reviewed commits have been landed. Closing PR #9193 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Jan 28, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Convert-AnalyzeAPITestsResults-to-new-style-buildstep branch January 30, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aj062 aj062 aj062 approved these changes

@ryanhaddad ryanhaddad Awaiting requested review from ryanhaddad ryanhaddad is a code owner

Assignees

@JonWBedard JonWBedard

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@JonWBedard @webkit-early-warning-system @webkit-commit-queue @aj062 @webkit-ews-buildbot