Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid unnecessary calls to fastZeroedMalloc() in FastBitVector #923

Merged
merged 0 commits into from May 24, 2022
Merged

Avoid unnecessary calls to fastZeroedMalloc() in FastBitVector #923

merged 0 commits into from May 24, 2022

Conversation

cdumez
Copy link
Contributor

@cdumez cdumez commented May 23, 2022 •
edited by webkit-early-warning-system

197387a

Avoid unnecessary calls to fastZeroedMalloc() in FastBitVector
https://bugs.webkit.org/show_bug.cgi?id=240812

Reviewed by Yusuke Suzuki.

We were calling fastZeroedMalloc() which would allocate the memory and memset it to 0,
only to then overwrite all (or most) of that memory with memcpy().

* Source/WTF/wtf/FastBitVector.cpp:
(WTF::FastBitVectorWordOwner::setEqualsSlow):
(WTF::FastBitVectorWordOwner::resizeSlow):

Canonical link: https://commits.webkit.org/250918@main
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@294750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

@cdumez cdumez self-assigned this May 23, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 23, 2022
@cdumez cdumez removed the merging-blocked Applied to prevent a change from being merged label May 23, 2022
@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 23, 2022
Constellation
Constellation approved these changes May 24, 2022
View reviewed changes
Copy link
Member

@Constellation Constellation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cdumez cdumez added merge-queue Applied to send a pull request to merge-queue and removed merging-blocked Applied to prevent a change from being merged labels May 24, 2022
@webkit-early-warning-system webkit-early-warning-system merged commit 197387a into WebKit:main May 24, 2022
@webkit-early-warning-system
Copy link
Collaborator

Committed r294750 (250918@main): https://commits.webkit.org/250918@main

Reviewed commits have been landed. Closing PR #923 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system removed the merge-queue Applied to send a pull request to merge-queue label May 24, 2022
@cdumez cdumez deleted the 240812_FastBitVector_fastMalloc branch May 24, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Constellation Constellation Constellation approved these changes

@saambarati saambarati Awaiting requested review from saambarati

@geoffreygaren geoffreygaren Awaiting requested review from geoffreygaren

@MenloDorian MenloDorian Awaiting requested review from MenloDorian

Assignees

@cdumez cdumez

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@cdumez @webkit-early-warning-system @Constellation