Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Convert RemoveFlagsOnPatch to Twisted asynchronous requests #9244

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 27, 2023

@JonWBedard JonWBedard self-assigned this Jan 27, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 27, 2023
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming it's tested

@JonWBedard JonWBedard added the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 2, 2023
…nous requests

https://bugs.webkit.org/show_bug.cgi?id=251281
rdar://104752905

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(BugzillaMixin.remove_flags_on_patch): Convert to Twisted asynchronous requests.
(RemoveFlagsOnPatch.run): Renamed from start.
(RemoveFlagsOnPatch.start): Renamed to run.

Canonical link: https://commits.webkit.org/259728@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/ews-build-webkit-org-Convert-RemoveFlagsOnPatch-to-Twisted-asynchronous-requests branch from e0e10ea to 31ea862 Compare February 2, 2023 01:32
@webkit-early-warning-system webkit-early-warning-system merged commit 31ea862 into WebKit:main Feb 2, 2023
@webkit-commit-queue
Copy link
Collaborator

Committed 259728@main (31ea862): https://commits.webkit.org/259728@main

Reviewed commits have been landed. Closing PR #9244 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Feb 2, 2023
@JonWBedard JonWBedard deleted the eng/ews-build-webkit-org-Convert-RemoveFlagsOnPatch-to-Twisted-asynchronous-requests branch February 2, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants