Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a few scrolling tests with UI-side compositing enabled #9270

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Jan 28, 2023

095a062

Fix a few scrolling tests with UI-side compositing enabled
https://bugs.webkit.org/show_bug.cgi?id=251308
<rdar://problem/104772791>

Reviewed by Alan Baradlay.

* LayoutTests/fast/events/wheel/wheel-event-destroys-overflow.html: Enable AsyncOverflowScrollingEnabled and use UIHelper.mouseWheelScrollAt().
* LayoutTests/fast/scrolling/latching/latched-scroll-remove-iframe.html: Wait for a presentation update.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/mac/latching/horizontal-overflow-in-vertical-overflow-expected.txt: Removed; test passes now.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/mac/latching/zero-delta-began-should-not-latch-expected.txt: Removed; test passes now.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed; test passes now.
* LayoutTests/platform/win/TestExpectations: monitorWheelEvents tests time out.
* LayoutTests/platform/gtk/TestExpectations: ditto.

Canonical link: https://commits.webkit.org/259597@main

76c01f7

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
❌ πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@smfr smfr requested a review from rniwa as a code owner January 28, 2023 04:37
@smfr smfr self-assigned this Jan 28, 2023
@smfr smfr added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 28, 2023
@smfr smfr force-pushed the eng/Fix-a-few-scrolling-tests-with-UI-side-compositing-enabled branch from 8c3cb79 to 13ac3ca Compare January 28, 2023 04:46
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 28, 2023
@smfr smfr removed the merging-blocked Applied to prevent a change from being merged label Jan 30, 2023
@smfr smfr force-pushed the eng/Fix-a-few-scrolling-tests-with-UI-side-compositing-enabled branch from 13ac3ca to 76c01f7 Compare January 30, 2023 19:50
@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Fix-a-few-scrolling-tests-with-UI-side-compositing-enabled branch from 76c01f7 to f941e53 Compare January 31, 2023 00:50
https://bugs.webkit.org/show_bug.cgi?id=251308
<rdar://problem/104772791>

Reviewed by Alan Baradlay.

* LayoutTests/fast/events/wheel/wheel-event-destroys-overflow.html: Enable AsyncOverflowScrollingEnabled and use UIHelper.mouseWheelScrollAt().
* LayoutTests/fast/scrolling/latching/latched-scroll-remove-iframe.html: Wait for a presentation update.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/mac/latching/horizontal-overflow-in-vertical-overflow-expected.txt: Removed; test passes now.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/mac/latching/zero-delta-began-should-not-latch-expected.txt: Removed; test passes now.
* LayoutTests/platform/mac-gpup/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe-expected.txt: Removed; test passes now.
* LayoutTests/platform/win/TestExpectations: monitorWheelEvents tests time out.
* LayoutTests/platform/gtk/TestExpectations: ditto.

Canonical link: https://commits.webkit.org/259597@main
@webkit-early-warning-system webkit-early-warning-system force-pushed the eng/Fix-a-few-scrolling-tests-with-UI-side-compositing-enabled branch from f941e53 to 095a062 Compare January 31, 2023 00:53
@webkit-commit-queue
Copy link
Collaborator

Committed 259597@main (095a062): https://commits.webkit.org/259597@main

Reviewed commits have been landed. Closing PR #9270 and removing active labels.

@webkit-early-warning-system webkit-early-warning-system merged commit 095a062 into WebKit:main Jan 31, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
@smfr smfr deleted the eng/Fix-a-few-scrolling-tests-with-UI-side-compositing-enabled branch February 22, 2023 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
5 participants