Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Wasm-GC] Fix structure TypeInfo for JSWebAssemblyStruct #9275

Closed
wants to merge 1 commit into from

Conversation

catamorphism
Copy link
Contributor

@catamorphism catamorphism commented Jan 28, 2023

5e75a56

[Wasm-GC] Fix structure `TypeInfo` for `JSWebAssemblyStruct`
https://bugs.webkit.org/show_bug.cgi?id=250613

Reviewed by NOBODY (OOPS!).

Previously, the `JSWebAssemblyStruct::createStructure()` method was passing in
`FinalObjectType` as its `TypeInfo` when creating a `Structure`. This was
inconsistent with the declaration of the `JSWebAssemblyStruct` class, which
inherits from `JSNonFinalObject`. Use `ObjectType` to be consistent with
the inheritance declaration.

* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h:

5e75a56

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk   πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac   πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1   πŸ§ͺ api-gtk
βœ… πŸ›  πŸ§ͺ jsc βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2 βœ… πŸ›  jsc-armv7
βœ… πŸ›  πŸ§ͺ jsc-arm64 βœ… πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2 βœ… πŸ§ͺ jsc-armv7-tests
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress βœ… πŸ›  jsc-mips
βœ… πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim βœ… πŸ§ͺ jsc-mips-tests

@catamorphism catamorphism changed the title Don't make WebAssembly structs use FinalObjectType in their structures' TypeInfo [Wasm-GC] Fix structure TypeInfo for JSWebAssemblyStruct Jan 29, 2023
https://bugs.webkit.org/show_bug.cgi?id=250613

Reviewed by NOBODY (OOPS!).

Previously, the `JSWebAssemblyStruct::createStructure()` method was passing in
`FinalObjectType` as its `TypeInfo` when creating a `Structure`. This was
inconsistent with the declaration of the `JSWebAssemblyStruct` class, which
inherits from `JSNonFinalObject`. Use `ObjectType` to be consistent with
the inheritance declaration.

* Source/JavaScriptCore/wasm/js/JSWebAssemblyStruct.h:
@catamorphism catamorphism deleted the isolating-gc-bug branch January 29, 2023 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants