-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ews-build.webkit.org] Convert AnalyzeCompileWebKitResults to a new-style buildstep #9316
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ assuming this is tested
EWS run on previous version of this PR (hash a644ca9) |
a644ca9
to
b21c0d4
Compare
EWS run on previous version of this PR (hash b21c0d4) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ assuming this is tested.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r+ assuming this is tested.
EWS run on current version of this PR (hash 9947af5) |
9947af5
to
b1464db
Compare
β¦tyle buildstep https://bugs.webkit.org/show_bug.cgi?id=251303 rdar://104767890 Reviewed by Aakash Jain. * Tools/CISupport/ews-build/steps.py: (AnalyzeCompileWebKitResults.run): Renamed from start. (AnalyzeCompileWebKitResults.analyzeResults): Return status. (AnalyzeCompileWebKitResults.getResults): Correct early returns. (AnalyzeCompileWebKitResults.start): Renamed to run. Canonical link: https://commits.webkit.org/261273@main
b1464db
to
0bd68d6
Compare
Committed 261273@main (0bd68d6): https://commits.webkit.org/261273@main Reviewed commits have been landed. Closing PR #9316 and removing active labels. |
0bd68d6
9947af5
π§ͺ styleπ iosπ macπ wpeπ wincairoπ§ͺ bindingsπ ios-simπ mac-AS-debugπ§ͺ wpe-wk2π§ͺ webkitperlπ§ͺ ios-wk2π§ͺ api-macπ gtkπ§ͺ api-iosπ§ͺ mac-wk1π§ͺ gtk-wk2π tvπ§ͺ mac-wk2π§ͺ api-gtkπ tv-simπ§ͺ mac-AS-debug-wk2π§ͺ servicesπ watchπ§ͺ mac-wk2-stressπ watch-sim