Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ews-build.webkit.org] Convert AnalyzeCompileWebKitResults to a new-style buildstep #9316

Merged
merged 1 commit into from
Mar 6, 2023

Conversation

JonWBedard
Copy link
Member

@JonWBedard JonWBedard commented Jan 30, 2023

0bd68d6

[ews-build.webkit.org] Convert AnalyzeCompileWebKitResults to a new-style buildstep
https://bugs.webkit.org/show_bug.cgi?id=251303
rdar://104767890

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.run): Renamed from start.
(AnalyzeCompileWebKitResults.analyzeResults): Return status.
(AnalyzeCompileWebKitResults.getResults): Correct early returns.
(AnalyzeCompileWebKitResults.start): Renamed to run.

Canonical link: https://commits.webkit.org/261273@main

9947af5

Misc iOS, tvOS & watchOS macOS Linux Windows
  πŸ§ͺ style   πŸ›  ios   πŸ›  mac   πŸ›  wpe   πŸ›  wincairo
  πŸ§ͺ bindings   πŸ›  ios-sim   πŸ›  mac-AS-debug   πŸ§ͺ wpe-wk2
  πŸ§ͺ webkitperl   πŸ§ͺ ios-wk2   πŸ§ͺ api-mac   πŸ›  gtk
  πŸ§ͺ api-ios   πŸ§ͺ mac-wk1   πŸ§ͺ gtk-wk2
  πŸ›  tv   πŸ§ͺ mac-wk2   πŸ§ͺ api-gtk
  πŸ›  tv-sim   πŸ§ͺ mac-AS-debug-wk2
  πŸ§ͺ services   πŸ›  watch   πŸ§ͺ mac-wk2-stress
  πŸ›  watch-sim
❌ πŸ›  πŸ§ͺ unsafe-merge

@JonWBedard JonWBedard self-assigned this Jan 30, 2023
@JonWBedard JonWBedard added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 30, 2023
Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested

Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested.

Copy link
Member

@aj062 aj062 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+ assuming this is tested.

@JonWBedard JonWBedard added skip-ews Applied to prevent a change from being run on EWS unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing labels Mar 6, 2023
…tyle buildstep

https://bugs.webkit.org/show_bug.cgi?id=251303
rdar://104767890

Reviewed by Aakash Jain.

* Tools/CISupport/ews-build/steps.py:
(AnalyzeCompileWebKitResults.run): Renamed from start.
(AnalyzeCompileWebKitResults.analyzeResults): Return status.
(AnalyzeCompileWebKitResults.getResults): Correct early returns.
(AnalyzeCompileWebKitResults.start): Renamed to run.

Canonical link: https://commits.webkit.org/261273@main
@webkit-commit-queue
Copy link
Collaborator

Committed 261273@main (0bd68d6): https://commits.webkit.org/261273@main

Reviewed commits have been landed. Closing PR #9316 and removing active labels.

@webkit-commit-queue webkit-commit-queue removed the unsafe-merge-queue Applied to send a pull request to merge-queue, but skip building and testing label Mar 6, 2023
@webkit-early-warning-system webkit-early-warning-system merged commit 0bd68d6 into WebKit:main Mar 6, 2023
@JonWBedard JonWBedard deleted the eng/251303 branch March 14, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ews Applied to prevent a change from being run on EWS Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants