Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GStreamer] ElementHarness: Remove custom sink query handler #9319

Merged
merged 1 commit into from
Jan 31, 2023

Conversation

philn
Copy link
Member

@philn philn commented Jan 30, 2023

6c27891

[GStreamer] ElementHarness: Remove custom sink query handler
https://bugs.webkit.org/show_bug.cgi?id=251363

Reviewed by Xabier Rodriguez-Calvar.

In cases where the harnessed element reconfigures a source pad, the associated sink pad caps
need re-negotiation and it's better to let the default pad query handler do it.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::Stream::Stream):
(WebCore::GStreamerElementHarness::Stream::sinkQuery): Deleted.
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:

Canonical link: https://commits.webkit.org/259619@main

4a510b7

Misc iOS, tvOS & watchOS macOS Linux Windows
βœ… πŸ§ͺ style βœ… πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  wpe βœ… πŸ›  πŸ§ͺ win
βœ… πŸ§ͺ bindings βœ… πŸ›  ios-sim βœ… πŸ›  mac-AS-debug βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl βœ… πŸ§ͺ ios-wk2 βœ… πŸ§ͺ api-mac βœ… πŸ§ͺ gtk-wk2
βœ… πŸ§ͺ api-ios βœ… πŸ§ͺ mac-wk1 βœ… πŸ§ͺ api-gtk
βœ… πŸ›  tv βœ… πŸ§ͺ mac-wk2
βœ… πŸ›  tv-sim ❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ›  watch βœ… πŸ§ͺ mac-wk2-stress
❌ πŸ›  πŸ§ͺ merge βœ… πŸ›  watch-sim

@philn philn self-assigned this Jan 30, 2023
@philn philn added the Platform Portability improvements and other general platform improvements not driven directly by site bugs. label Jan 30, 2023
@philn philn requested a review from calvaris January 30, 2023 16:17
@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 30, 2023
@calvaris calvaris removed the merging-blocked Applied to prevent a change from being merged label Jan 31, 2023
@philn philn added the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
https://bugs.webkit.org/show_bug.cgi?id=251363

Reviewed by Xabier Rodriguez-Calvar.

In cases where the harnessed element reconfigures a source pad, the associated sink pad caps
need re-negotiation and it's better to let the default pad query handler do it.

* Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp:
(WebCore::GStreamerElementHarness::Stream::Stream):
(WebCore::GStreamerElementHarness::Stream::sinkQuery): Deleted.
* Source/WebCore/platform/gstreamer/GStreamerElementHarness.h:

Canonical link: https://commits.webkit.org/259619@main
@webkit-commit-queue
Copy link
Collaborator

Committed 259619@main (6c27891): https://commits.webkit.org/259619@main

Reviewed commits have been landed. Closing PR #9319 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 6c27891 into WebKit:main Jan 31, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
@philn philn deleted the eng/251363 branch January 31, 2023 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Platform Portability improvements and other general platform improvements not driven directly by site bugs.
Projects
None yet
5 participants