-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GStreamer] ElementHarness: Remove custom sink query handler #9319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philn
added
the
Platform
Portability improvements and other general platform improvements not driven directly by site bugs.
label
Jan 30, 2023
EWS run on current version of this PR (hash 4a510b7) |
EWS run on previous version of this PR (hash 5dcec9f) |
webkit-ews-buildbot
added
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 30, 2023
calvaris
approved these changes
Jan 31, 2023
calvaris
removed
the
merging-blocked
Applied to prevent a change from being merged
label
Jan 31, 2023
webkit-commit-queue
force-pushed
the
eng/251363
branch
from
January 31, 2023 09:53
4a510b7
to
3aa0088
Compare
https://bugs.webkit.org/show_bug.cgi?id=251363 Reviewed by Xabier Rodriguez-Calvar. In cases where the harnessed element reconfigures a source pad, the associated sink pad caps need re-negotiation and it's better to let the default pad query handler do it. * Source/WebCore/platform/gstreamer/GStreamerElementHarness.cpp: (WebCore::GStreamerElementHarness::Stream::Stream): (WebCore::GStreamerElementHarness::Stream::sinkQuery): Deleted. * Source/WebCore/platform/gstreamer/GStreamerElementHarness.h: Canonical link: https://commits.webkit.org/259619@main
webkit-commit-queue
force-pushed
the
eng/251363
branch
from
January 31, 2023 09:56
3aa0088
to
6c27891
Compare
Committed 259619@main (6c27891): https://commits.webkit.org/259619@main Reviewed commits have been landed. Closing PR #9319 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
Applied to send a pull request to merge-queue
label
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Platform
Portability improvements and other general platform improvements not driven directly by site bugs.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6c27891
4a510b7