Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR to test EWS comments on GitHub #933

Closed
wants to merge 1 commit into from

Conversation

@aj062 aj062 self-assigned this May 23, 2022
@aj062 aj062 added Other Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases labels May 23, 2022
@aj062
Copy link
Member Author

aj062 commented May 23, 2022

e928c17
πŸ›  Builders:
❌ ios βœ… mac βœ… mac-debug ⏳ mac-AS-debug ❌ ios-simβ€ƒβœ… tv βœ… tv-sim βœ… watch βœ… watch-sim βœ… gtk βœ… wpe ❌ win βœ… wincairo

πŸ§ͺ Testers:
❌ ios-wk2 ❌ mac-wk1 ❌ mac-wk2 ❌ mac-debug-wk1 ❌ mac-AS-debug-wk2 ❌ api-ios βœ… api-mac βœ… api-gtk

Other:
❌ style ❌ webkitpyβœ… bindings βœ… webkitperl ⏳ services

❌ πŸ› πŸ§ͺ win

Found 1 new test failure
 http/tests/websocket/tests/hybi/simple-wss.html

❌ πŸ§ͺ mac-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-debug-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-AS-debug-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

@aj062 aj062 changed the title Bug to test EWS PR to test EWS comments May 23, 2022
@aj062

This comment was marked as outdated.

@aj062 aj062 changed the title PR to test EWS comments PR to test EWS comments on GitHub May 23, 2022
https://bugs.webkit.org/show_bug.cgi?id=197467

Reviewed by NOBODY (OOPS!).

* Tools/CISupport/ews-build/steps.py:
(ShowIdentifier.__init__):
@aj062
Copy link
Member Author

aj062 commented May 23, 2022

0a73254
❌ πŸ§ͺ style
❌ πŸ§ͺ webkitpy
❌ πŸ›  ios
❌ πŸ›  ios-sim  
βœ… πŸ›  mac
βœ… πŸ›  mac-debug  
⏳ πŸ›  mac-AS-debug 
βœ… πŸ›  tv   
βœ… πŸ›  tv-sim  
βœ… πŸ›  watch
βœ… πŸ›  watch-sim  
βœ… πŸ›  gtk   
βœ… πŸ›  wpe   
βœ… πŸ›  wincairo  
❌ πŸ› πŸ§ͺ win
❌ πŸ§ͺ ios-wk2  
❌ πŸ§ͺ mac-wk1  
❌ πŸ§ͺ mac-wk2  
❌ πŸ§ͺ mac-debug-wk1 
❌ πŸ§ͺ mac-AS-debug-wk2
❌ πŸ§ͺ api-ios  
βœ… πŸ§ͺ api-mac  
βœ… πŸ§ͺ api-gtk  
βœ… πŸ§ͺ bindings  
βœ… πŸ§ͺ webkitperl
⏳ πŸ§ͺ services  

❌ πŸ› πŸ§ͺ win

Found 1 new test failure
 http/tests/websocket/tests/hybi/simple-wss.html

❌ πŸ§ͺ mac-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-debug-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-AS-debug-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

@webkit-early-warning-system webkit-early-warning-system added the merging-blocked Applied to prevent a change from being merged label May 24, 2022
@nt1m
Copy link
Member

nt1m commented May 24, 2022

@aj062 Maybe tables would look more fancy? Or maybe re-using the Github "Checks" tab like: https://github.com/web-platform-tests/wpt/pull/34170/checks

@@ -686,7 +686,7 @@ class ShowIdentifier(shell.ShellCommand):
haltOnFailure = False

def __init__(self, **kwargs):
shell.ShellCommand.__init__(self, timeout=5 * 60, logEnviron=False, **kwargs)
shell.ShellCommand.__init__(self, timeout=10 * 60, logEnviron=False, **kwargs)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to increase this timeout?

@aj062
Copy link
Member Author

aj062 commented May 26, 2022

0a73254

Tests iOS macOS tvOS & watchOS Linux Windows
❌ πŸ§ͺ style ❌ πŸ›  ios βœ… πŸ›  mac βœ… πŸ›  tv βœ… πŸ›  wpe ❌ πŸ› πŸ§ͺ win
❌ πŸ§ͺ webkitpy ❌ πŸ›  ios-sim βœ… πŸ›  mac-debug βœ… πŸ›  tv-sim βœ… πŸ›  gtk βœ… πŸ›  wincairo
βœ… πŸ§ͺ webkitperl ❌ πŸ§ͺ ios-wk2 ⏳ πŸ›  mac-AS-debug βœ… πŸ›  watch βœ… πŸ§ͺ api-gtk
βœ… πŸ§ͺ bindings ❌ πŸ§ͺ api-ios ❌ πŸ§ͺ mac-wk1 βœ… πŸ›  watch-sim
⏳ πŸ§ͺ services ❌ πŸ§ͺ mac-wk2
❌ πŸ§ͺ mac-debug-wk1
❌ πŸ§ͺ mac-AS-debug-wk2
βœ… πŸ§ͺ api-mac

❌ πŸ› πŸ§ͺ win

Found 1 new test failure
 http/tests/websocket/tests/hybi/simple-wss.html

❌ πŸ§ͺ mac-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-debug-wk1

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

❌ πŸ§ͺ mac-AS-debug-wk2

Found 5 new test failures
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...
 fast/overflow/inline-block-scroll-overflow.html...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merging-blocked Applied to prevent a change from being merged Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
4 participants