New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR to test EWS comments on GitHub #933
Conversation
e928c17 π§ͺ Testers: Other: β π π§ͺ winFound 1 new test failure β π§ͺ mac-wk1Found 5 new test failures β π§ͺ mac-wk2Found 5 new test failures β π§ͺ mac-debug-wk1Found 5 new test failures β π§ͺ mac-AS-debug-wk2Found 5 new test failures |
e928c17
to
af01ebb
Compare
This comment was marked as outdated.
This comment was marked as outdated.
af01ebb
to
0a73254
Compare
https://bugs.webkit.org/show_bug.cgi?id=197467 Reviewed by NOBODY (OOPS!). * Tools/CISupport/ews-build/steps.py: (ShowIdentifier.__init__):
0a73254 β π π§ͺ winFound 1 new test failure β π§ͺ mac-wk1Found 5 new test failures β π§ͺ mac-wk2Found 5 new test failures β π§ͺ mac-debug-wk1Found 5 new test failures β π§ͺ mac-AS-debug-wk2Found 5 new test failures |
@aj062 Maybe tables would look more fancy? Or maybe re-using the Github "Checks" tab like: https://github.com/web-platform-tests/wpt/pull/34170/checks |
@@ -686,7 +686,7 @@ class ShowIdentifier(shell.ShellCommand): | |||
haltOnFailure = False | |||
|
|||
def __init__(self, **kwargs): | |||
shell.ShellCommand.__init__(self, timeout=5 * 60, logEnviron=False, **kwargs) | |||
shell.ShellCommand.__init__(self, timeout=10 * 60, logEnviron=False, **kwargs) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to increase this timeout?
β π π§ͺ winFound 1 new test failure β π§ͺ mac-wk1Found 5 new test failures β π§ͺ mac-wk2Found 5 new test failures β π§ͺ mac-debug-wk1Found 5 new test failures β π§ͺ mac-AS-debug-wk2Found 5 new test failures |
Updated comment by EWS
|
Updated comment by EWS
|
EWS run on previous version of this PR (hash de513128c68140362ae4d5b1975cf0f4d2688808)
Updated comment by EWS
https://github.com/WebKit/WebKit/commit/de513128c68140362ae4d5b1975cf0f4d2688808
|
Automated comment by EWS
|
|
|
|
|
|
|
EWS run on previous version of this PR (hash 98de33c)
|
EWS run on previous version of this PR (hash c7bc077)
|
|
|
|
|
|
EWS run on previous version of this PR (hash bd9994f)
|
EWS run on previous version of this PR (hash 837c761)
|
EWS run on previous version of this PR (hash a96a433)
|
|
|
|
EWS run on previous version of this PR (hash 42e7bf5)
|
|
|
|
|
|
|
|
|
|
|
EWS run on current version of this PR (hash ef15955)
|
ef15955
ef15955
π§ͺ style