Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Running WebKitTestRunner with --webkitlogging foo doesn't turn on logging channels #9347

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Running WebKitTestRunner with --webkitlogging foo doesn't turn on logging channels #9347

merged 1 commit into from
Jan 31, 2023

Conversation

smfr
Copy link
Contributor

@smfr smfr commented Jan 30, 2023 •
edited by webkit-early-warning-system

7e5eb42

Running WebKitTestRunner with `--webkitlogging foo` doesn't turn on logging channels
https://bugs.webkit.org/show_bug.cgi?id=251395
rdar://104837852

Reviewed by Tim Horton and Wenson Hsieh.

The NSUserDefault for WebKit logging channels still has the historical "WebKit2" in the name.

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize):

Canonical link: https://commits.webkit.org/259607@main

9a8e9e5

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@smfr smfr requested a review from JonWBedard as a code owner January 30, 2023 22:38
@smfr smfr self-assigned this Jan 30, 2023
@smfr smfr added the Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases label Jan 30, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash 9a8e9e5)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ✅ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ✅ 🧪 ios-wk2 ✅ 🧪 api-mac ✅ 🧪 gtk-wk2
✅ 🧪 api-ios ✅ 🧪 mac-wk1   🧪 api-gtk
✅ 🛠 tv ✅ 🧪 mac-wk2
✅ 🛠 tv-sim   🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 🧪 merge ✅ 🛠 watch-sim

@smfr smfr added the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
@smfr
Running WebKitTestRunner with --webkitlogging foo doesn't turn on l…
7e5eb42 
…ogging channels

https://bugs.webkit.org/show_bug.cgi?id=251395
rdar://104837852

Reviewed by Tim Horton and Wenson Hsieh.

The NSUserDefault for WebKit logging channels still has the historical "WebKit2" in the name.

* Tools/WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize):

Canonical link: https://commits.webkit.org/259607@main
@webkit-commit-queue webkit-commit-queue force-pushed the eng/Running-WebKitTestRunner-with---webkitlogging-foo-doesnt-turn-on-logging-channels branch from 9a8e9e5 to 7e5eb42 Compare January 31, 2023 07:28
@webkit-commit-queue
Copy link
Collaborator

Committed 259607@main (7e5eb42): https://commits.webkit.org/259607@main

Reviewed commits have been landed. Closing PR #9347 and removing active labels.

@webkit-commit-queue webkit-commit-queue merged commit 7e5eb42 into WebKit:main Jan 31, 2023
@webkit-commit-queue webkit-commit-queue removed the merge-queue Applied to send a pull request to merge-queue label Jan 31, 2023
@smfr smfr deleted the eng/Running-WebKitTestRunner-with---webkitlogging-foo-doesnt-turn-on-logging-channels branch February 22, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortont424 hortont424 hortont424 approved these changes

@whsieh whsieh whsieh approved these changes

@JonWBedard JonWBedard Awaiting requested review from JonWBedard JonWBedard is a code owner

Assignees

@smfr smfr

Labels
Tools / Tests Tools in the Tools directory, build issues, test infrastructure, and bugs in test cases
Projects
None yet
Milestone
No milestone
5 participants
@smfr @webkit-early-warning-system @webkit-commit-queue @hortont424 @whsieh