Use a different layer border color with UI-side compositing #9358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smfr
added
the
Compositing
hortont424
approved these changes
Jan 31, 2023
|
EWS run on previous version of this PR (hash 8ef0b7c)
|
webkit-ews-buildbot
added
the
merging-blocked
weinig
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
@hortont424 knows my request for a legend to identify what these colors mean still stands.
smfr
force-pushed
the
eng/Use-a-different-layer-border-color-with-UI-side-compositing
branch
from
8ef0b7c
to
9fbb234
Compare
|
EWS run on current version of this PR (hash 9fbb234)
|
webkit-early-warning-system
force-pushed
the
eng/Use-a-different-layer-border-color-with-UI-side-compositing
branch
2 times, most recently
from
515eb88
to
18d49fc
Compare
https://bugs.webkit.org/show_bug.cgi?id=251406 <rdar://problem/104844082> Reviewed by Sam Weinig and Tim Horton. The value returned by GraphicsLayerCA::pageTiledBackingBorderColor() will be the legacy page tile border color once UI-side compositing is enabled by default. Change it to something more navy/gray, so that it can be distinguished from the UI-side compositing colors in screenshots. Also do a drive-by fix where the RemoteLayerTreeDrawingArea "root" layer should not get sized to the contents size on macOS, where we don't delegate scrolling to a native view. * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp: (WebCore::GraphicsLayerCA::pageTiledBackingBorderColor const): (WebCore::GraphicsLayerCA::getDebugBorderInfo const): * Source/WebCore/platform/graphics/ca/GraphicsLayerCA.h: * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.cpp: (WebKit::GraphicsLayerCARemote::pageTiledBackingBorderColor const): * Source/WebKit/WebProcess/WebPage/RemoteLayerTree/GraphicsLayerCARemote.h: * Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.h: * Source/WebKit/WebProcess/WebPage/mac/RemoteLayerTreeDrawingAreaMac.mm: (WebKit::RemoteLayerTreeDrawingAreaMac::mainFrameContentSizeChanged): Canonical link: https://commits.webkit.org/259637@main
webkit-early-warning-system
force-pushed
the
eng/Use-a-different-layer-border-color-with-UI-side-compositing
branch
from
18d49fc
to
288bbe8
Compare
|
Committed 259637@main (288bbe8): https://commits.webkit.org/259637@main Reviewed commits have been landed. Closing PR #9358 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
smfr
deleted the
eng/Use-a-different-layer-border-color-with-UI-side-compositing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
288bbe8
9fbb234
🛠 ios🛠 mac🛠 🧪 win🛠 ios-sim🛠 mac-AS-debug🛠 wincairo🧪 ios-wk2🧪 api-mac🧪 gtk-wk2🧪 api-ios🧪 mac-wk1🧪 api-gtk🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2🛠 watch🧪 mac-wk2-stress🛠 watch-sim