Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use CheckedPtr for m_preloads in CachedResourceLoader #9386

Closed
wants to merge 1 commit into from
Closed

Use CheckedPtr for m_preloads in CachedResourceLoader #9386

wants to merge 1 commit into from

Conversation

rniwa
Copy link
Member

@rniwa rniwa commented Jan 31, 2023 •
edited by webkit-early-warning-system

b572acb

Use CheckedPtr for m_preloads in CachedResourceLoader
https://bugs.webkit.org/show_bug.cgi?id=251440

Reviewed by NOBODY (OOPS!).

Made it possible to make CheckedPtr for CachedResource and deployed it in CachedResourceLoader::m_preloads.

* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::isLinkPreload const):
(WebCore::CachedResource::isLinkPreload): Made this accessor function const.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::clearPreloads):
* Source/WebCore/loader/cache/CachedResourceLoader.h:

b572acb

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@rniwa
Use CheckedPtr for m_preloads in CachedResourceLoader
b572acb 
https://bugs.webkit.org/show_bug.cgi?id=251440

Reviewed by NOBODY (OOPS!).

Made it possible to make CheckedPtr for CachedResource and deployed it in CachedResourceLoader::m_preloads.

* Source/WebCore/loader/cache/CachedResource.h:
(WebCore::CachedResource::isLinkPreload const):
(WebCore::CachedResource::isLinkPreload): Made this accessor function const.
* Source/WebCore/loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::preload):
(WebCore::CachedResourceLoader::clearPreloads):
* Source/WebCore/loader/cache/CachedResourceLoader.h:
@rniwa rniwa requested a review from cdumez as a code owner January 31, 2023 17:35
@rniwa rniwa self-assigned this Jan 31, 2023
@rniwa rniwa added the Page Loading For bugs in page loading, including handling of network callbacks. label Jan 31, 2023
@webkit-early-warning-system
Copy link
Collaborator

EWS run on current version of this PR (hash b572acb)

Misc iOS, tvOS & watchOS macOS Linux Windows
✅ 🧪 style ✅ 🛠 ios ✅ 🛠 mac ✅ 🛠 wpe ❌ 🛠 🧪 win
✅ 🧪 bindings ✅ 🛠 ios-sim ✅ 🛠 mac-AS-debug ✅ 🛠 gtk ✅ 🛠 wincairo
✅ 🧪 webkitperl ❌ 🧪 ios-wk2 ✅ 🧪 api-mac ❌ 🧪 gtk-wk2
✅ 🧪 api-ios ❌ 🧪 mac-wk1 ❌ 🧪 api-gtk
✅ 🛠 tv ❌ 🧪 mac-wk2
✅ 🛠 tv-sim ❌ 🧪 mac-AS-debug-wk2
✅ 🛠 watch ✅ 🧪 mac-wk2-stress
✅ 🛠 watch-sim

@webkit-ews-buildbot webkit-ews-buildbot added the merging-blocked Applied to prevent a change from being merged label Jan 31, 2023
achristensen07
achristensen07 requested changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@achristensen07 achristensen07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures look related

@rniwa
Copy link
Member Author

rniwa commented Feb 1, 2023

Test failures look related

Indeed...

@rniwa rniwa closed this Feb 2, 2023
@rniwa rniwa deleted the fix251440 branch February 2, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achristensen07 achristensen07 achristensen07 requested changes

@cdumez cdumez Awaiting requested review from cdumez cdumez is a code owner

Assignees

@rniwa rniwa

Labels
merging-blocked Applied to prevent a change from being merged Page Loading For bugs in page loading, including handling of network callbacks.
Projects
None yet
Milestone
No milestone
4 participants
@rniwa @webkit-early-warning-system @achristensen07 @webkit-ews-buildbot