[WGSL] Ignore extraneous semicolons in statements and declarations #9389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
EWS run on previous version of this PR (hash 91962ad)
|
litherum
reviewed
Feb 1, 2023
Source/WebGPU/WGSL/Parser.cpp
Outdated
| @@ -530,16 +535,16 @@ Expected<UniqueRef<AST::Statement>, Error> Parser<Lexer>::parseStatement() | |||
| { | |||
| START_PARSE(); | |||
|
|
|||
| if (current().m_type == TokenType::Semicolon) { | |||
| consume(); | |||
| return parseStatement(); | |||
There was a problem hiding this comment.
Shouldn't this be a loop instead of recursive? (I'm thinking about stack space)
litherum
approved these changes
Feb 1, 2023
tadeuzagallo
force-pushed
the
eng/WGSL-Ignore-extraneous-commas-in-statements-and-declarations
branch
from
91962ad
to
a80cb1b
Compare
|
EWS run on current version of this PR (hash a80cb1b)
|
https://bugs.webkit.org/show_bug.cgi?id=251442 rdar://104873247 Reviewed by Myles C. Maxfield. Update parser to match the spec: semicolons are valid statements and declarations. Add the code to `parseGlobalDecl` to skip semicolons and update `parseStatement` so we don't allocate an empty node if we find extraneous semicolons. * Source/WebGPU/WGSL/Parser.cpp: (WGSL::Parser<Lexer>::parseGlobalDecl): (WGSL::Parser<Lexer>::parseStatement): Canonical link: https://commits.webkit.org/259668@main
webkit-early-warning-system
force-pushed
the
eng/WGSL-Ignore-extraneous-commas-in-statements-and-declarations
branch
from
a80cb1b
to
4ce5ef2
Compare
|
Committed 259668@main (4ce5ef2): https://commits.webkit.org/259668@main Reviewed commits have been landed. Closing PR #9389 and removing active labels. |
webkit-commit-queue
removed
the
merge-queue
tadeuzagallo
deleted the
eng/WGSL-Ignore-extraneous-commas-in-statements-and-declarations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
4ce5ef2
a80cb1b
🛠 gtk🛠 wincairo🧪 ios-wk2🧪 gtk-wk2🧪 api-ios🧪 api-gtk🧪 mac-wk2🛠 tv-sim🧪 mac-AS-debug-wk2